mdb: disable console warnings if the debugger is present.
PATCH 21/28 mdb: disable console warnings if the debugger is present.
disable the console warning checks if the debugger is active because the debugger is dependent in the console output functions in order to provide console display.
include/linux/console.h +5 -0
@@ -141,11 +141,16 @@void vcs_remove_sysfs (struct tty_struct *tty);/* Some debug stub to catch some of the obvious races in the VT code */ + +#if defined(CONFIG_MDB ) || defined(CONFIG_MDB_MODULE ) +#define WARN_CONSOLE_UNLOCKED () +#else #if 1 #define WARN_CONSOLE_UNLOCKED () WARN_ON(!is_console_locked() && !oops_in_progress)#else #define WARN_CONSOLE_UNLOCKED ()#endif +#endif /* CONFIG_MDB */ /* VESA Blanking Levels */ #define VESA_NO_BLANKING 0
include/linux/console.h line 153
Quoted 12 lines · [email protected] writes:
/* Some debug stub to catch some of the obvious races in the VT code */
include/linux/console.h +5
-0+ +#if defined(CONFIG_MDB ) || defined(CONFIG_MDB_MODULE ) +#define WARN_CONSOLE_UNLOCKED () +#else #if 1 #define WARN_CONSOLE_UNLOCKED () WARN_ON(!is_console_locked() && !oops_in_progress)#else #define WARN_CONSOLE_UNLOCKED ()#endif +#endif /* CONFIG_MDB */
The obvious alternative would be to just set oops_in_progress while the debugger runs.
-Andi
Quoted 18 lines
Quoted 8 lines · [email protected] writes:
/* Some debug stub to catch some of the obvious races in the VT code */
include/linux/console.h +4
-0+ +#if defined(CONFIG_MDB ) || defined(CONFIG_MDB_MODULE ) +#define WARN_CONSOLE_UNLOCKED () +#else #if 1 #define WARN_CONSOLE_UNLOCKED () WARN_ON(!is_console_locked() &&Quoted 5 lines
!oops_in_progress)
#else
#defineWARN_CONSOLE_UNLOCKED()
#endif
+#endif /*CONFIG_MDB*/The obvious alternative would be to just set
oops_in_progresswhile the debugger runs.
Quoted 2 lines
-Andi
Also added to the list. that would remove the need for this patch, which would also benefit kdb since it also has a similar patch in this file too.
I will roll these fixes into the rc4 patch.
Jeff