Skip to contentSkip to conversation

posix-timers: use "struct pid*" instead of "struct task_struct*"

PATCH New Oleg Nesterov 1 participant 1 message Aug 20, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 posix-timers: use "struct pid*" instead of "struct task_struct*"

k_itimer holds the ref to the ->it_process until sys_timer_delete(). This allows to pin up to RLIMIT_SIGPENDING dead task_struct's. Change the code to use "struct pid *" instead.

The patch doesn't kill ->it_process, it places ->it_pid into the union. ->it_process is still used by do_cpu_nanosleep() as before. It would be trivial to change the nanosleep code as well, but since it uses it_process in a special way I think it is better to keep this field for grep.

The patch bloats the kernel by 104 bytes and it also adds the new pointer, ->it_signal, to k_itimer. It is used by lock_timer() to verify that the found timer was not created by another process. It is not clear why do we use the global database (and thus the global idr_lock) for posix timers. We still need the signal_struct->posix_timers which contains all useable timers, perhaps it is better to use some form of per-process array instead.

 include/linux/posix-timers.h |    6 +++++-
 kernel/posix-timers.c        |   43 +++++++++++++++++++++++--------------------
 2 files changed, 28 insertions(+), 21 deletions(-)
include/linux/posix-timers.h renamed from include/linux/posix-timers.h~11_S_TASK_PID +5 -1
@@ -45,7 +45,11 @@ struct k_itimer {
 	int it_requeue_pending;		/* waiting to requeue this timer */
 #define REQUEUE_PENDING 1
 	int it_sigev_notify;		/* notify word of sigevent struct */
-	struct task_struct *it_process;	/* process to send signal to */
+	struct signal_struct *it_signal;
+	union {
+		struct pid *it_pid;	/* pid of process to send signal to */
+		struct task_struct *it_process;	/* for clock_nanosleep */
+	};
 	struct sigqueue *sigq;		/* signal queue entry. */
 	union {
 		struct {
kernel/posix-timers.c renamed from kernel/posix-timers.c~11_S_TASK_PID +23 -20

118 lines not on this page · raw message