Skip to contentSkip to conversation

block bits

GIT PULL Jens Axboe 4 participants 6 messages Aug 26, 2008 – Aug 27, 2008 2 messages not in the archive

lore
Share & tools
lore

Jens Axboe

author
#0 lore raw

Hi Linus,

A small collection of fixes for 2.6.27, please apply.

git://git.kernel.dk/linux-2.6-block.git for-linus

Adel Gadllah (1):
block: clean up cmdfilter sysfs interface

FUJITA Tomonori (5):
block: move cmdfilter from gendisk to request_queue
sg: restore command permission for TYPE_SCANNER
block: rename blk_scsi_cmd_filter to blk_cmd_filter
bio: fix bio_copy_kern() handling of bio->bv_len
bio: fix __bio_copy_iov() handling of bio->bv_len

Jens Axboe (2):
block: submit_bh() inadvertently discards barrier flag on a sync write
block: remove blk_queue_tag_depth() and blk_queue_tag_queue()

Matthew Wilcox (1):

      block: remove unused ->busy part of the block queue tag map

[email protected] (1):
SG_IO block filter whitelist missing MMC SET READ AHEAD command

 block/blk-core.c       |    2 +
 block/blk-tag.c        |    6 +-
 block/bsg.c            |   44 +++--------
 block/cmd-filter.c     |  196 ++++++++++++------------------------------------
 block/scsi_ioctl.c     |   95 ++++++++++++++++++++++-
 drivers/scsi/sg.c      |   17 ++++-
 fs/bio.c               |   48 ++++++++----
 fs/buffer.c            |   13 ++-
 include/linux/blkdev.h |   18 +++-
 include/linux/genhd.h  |   10 ---
 10 files changed, 224 insertions(+), 225 deletions(-)
Signature · 1 line
Jens Axboe

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 3 lines · Jens Axboe

I'll move those 1-2 patches to the 2.6.28 branch and resubmit the rest for you.

You will *delete* the absolute crap locking patch, that has no way of being even 2.6.28 material.

And you need to be a whole lot more careful.

Linus

author
#4 lore raw
Quoted 9 lines · Linus Torvalds
Quoted 3 lines · Jens Axboe

I'll move those 1-2 patches to the 2.6.28 branch and resubmit the rest for you.

You will *delete* the absolute crap locking patch, that has no way of being even 2.6.28 material.

Yeah, I thought that was obvious, I'll bounce it back to the Xen folks.

Quoted 1 line

And you need to be a whole lot more careful.

Noted, I'll stick to the straight and narrow.

Signature · 1 line
Jens Axboe
#5 lore raw
Quoted 4 lines · Jens Axboe
Quoted 2 lines · Linus Torvalds

On Tue, 26 Aug 2008, Jens Axboe wrote:

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

I'll move those 1-2 patches to the 2.6.28 branch and resubmit the rest for you.

You will *delete* the absolute crap locking patch, that has no way of being even 2.6.28 material.

Yeah, I thought that was obvious, I'll bounce it back to the Xen folks.

Which, what? Was there an objection to one of the blkfront patches? (I don't remember anything locking related in there anyway.)

J

author
#6 lore raw
Quoted 12 lines · Jeremy Fitzhardinge
Quoted 11 lines · Jens Axboe
Quoted 8 lines · Linus Torvalds
Quoted 3 lines · Jens Axboe

I'll move those 1-2 patches to the 2.6.28 branch and resubmit the rest for you.

You will *delete* the absolute crap locking patch, that has no way of being even 2.6.28 material.

Quoted 5 lines
Quoted 2 lines

Yeah, I thought that was obvious, I'll bounce it back to the Xen folks.

Which, what? Was there an objection to one of the blkfront patches? (I don't remember anything locking related in there anyway.)

I see Linus' initial reply didn't make it to the list, not sure why. This is what he said:

"it's so _incredibly_ broken that I refuse to pull any of the rest either, because the queue is obviously utter crap.

In fact, even the "explanation" for that one is shit:

"It shouldn't matter if an interrupt comes in whilst blkif_io_lock is
held, as it will block on the lock [...]"

where "as it will block" is apparently shorthand for "as it will deadlock and kill the machine"."

This is the patch in question:

http://git.kernel.dk/?p=linux-2.6-block.git;a=commitdiff;h=b58e9034c5e2424723948a63712eaf1332a76ab8;hp=5814f8d589a1daef3b1a6f3731fd65a858dc8466

and it doesn indeed look like crap. It DOES matter if an interrupt comes in on the local CPU while you are holding the blkif_io_lock, you'd be dead on the spot spinning forever in the irq handler.

Signature · 1 line
Jens Axboe
#7 lore raw
In reply to Linus Torvalds
Quoted 11 lines · Linus Torvalds
Quoted 3 lines · Jens Axboe

I'll move those 1-2 patches to the 2.6.28 branch and resubmit the rest for you.

You will *delete* the absolute crap locking patch, that has no way of being even 2.6.28 material.

And you need to be a whole lot more careful.

I can't find the mail you're replying to either in my inbox or on marc.info. I also can't really see any xen patch in the rev listing in Jens' initial mail. Something got lost her..