Skip to contentSkip to conversation

i2c-i801: SMBus patch for Intel Ibex Peak DeviceIDs

PATCH RESEND In review Seth Heasley 2 participants 2 messages Aug 28, 2008 – Aug 29, 2008

Subsystems (3)
I2C subsystem host drivers I2C I2C/smbus controller drivers for pc
lore
Share & tools
lore

Seth Heasley

author
#0 lore raw

PATCH RESEND 1/1 i2c-i801: SMBus patch for Intel Ibex Peak DeviceIDs

This patch adds the Intel Ibex Peak (PCH) SMBus Controller DeviceIDs.

Changes are reflected in i2c-i801.c in response to updates to pci_ids.h. The SMBus Controller is now referred to as PCI_DEVICE_ID_INTEL_PCH_SMBUS, a change to the old naming convention of PCI_DEVICE_ID_INTEL_PCH_x.

Signed-off-by Seth Heasley <[email protected]>
Documentation/i2c/busses/i2c-i801 renamed from Documentation/i2c/busses/i2c-i801.orig +4 -3
@@ -13,8 +13,9 @@
   * Intel 631xESB/632xESB (ESB2)
   * Intel 82801H (ICH8)
   * Intel 82801I (ICH9)
-  * Intel Tolapai
-  * Intel ICH10
+  * Intel EP80579 (Tolapai)
+  * Intel 82801JI (ICH10)
+  * Intel PCH
    Datasheets: Publicly available at the Intel website
 
 Authors: 

@@ -32,7 +33,7 @@
 -----------
 
 The ICH (properly known as the 82801AA), ICH0 (82801AB), ICH2 (82801BA),
-ICH3 (82801CA/CAM) and later devices are Intel chips that are a part of
+ICH3 (82801CA/CAM) and later devices (PCH) are Intel chips that are a part of
 Intel's '810' chipset for Celeron-based PCs, '810E' chipset for
 Pentium-based PCs, '815E' chipset, and others.
drivers/i2c/busses/i2c-i801.c renamed from drivers/i2c/busses/i2c-i801.c.orig +2 -0
@@ -577,6 +577,7 @@
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TOLAPAI_1) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_4) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_5) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_PCH_SMBUS) },
 	{ 0, }
 };
 

@@ -600,6 +601,7 @@
 	case PCI_DEVICE_ID_INTEL_TOLAPAI_1:
 	case PCI_DEVICE_ID_INTEL_ICH10_4:
 	case PCI_DEVICE_ID_INTEL_ICH10_5:
+	case PCI_DEVICE_ID_INTEL_PCH_SMBUS:
 		i801_features |= FEATURE_I2C_BLOCK_READ;
 		/* fall through */
 	case PCI_DEVICE_ID_INTEL_82801DB_3:
drivers/i2c/busses/Kconfig renamed from drivers/i2c/busses/Kconfig.orig +1 -0
@@ -97,6 +97,7 @@
 	    ICH9
 	    Tolapai
 	    ICH10
+	    PCH
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called i2c-i801.
#1 lore raw

Hi Seth,

Quoted 7 lines · Seth Heasley

This patch adds the Intel Ibex Peak (PCH) SMBus Controller DeviceIDs.

Changes are reflected in i2c-i801.c in response to updates to pci_ids.h. The SMBus Controller is now referred to as PCI_DEVICE_ID_INTEL_PCH_SMBUS, a change to the old naming convention of PCI_DEVICE_ID_INTEL_PCH_x.

Except for a missing chunk in the header comment of i2c-i801.c (where we list the features of all supported devices) this looks OK to me. I've added that chunk back (your original patch had it.) As soon as the pci_ids.h patch is merged upstream, I'll add the i2c-i801 patch to my i2c tree.

Quoted 46 lines
Signed-off-by Seth Heasley <[email protected]>
Documentation/i2c/busses/i2c-i801 renamed from Documentation/i2c/busses/i2c-i801.orig +4 -3
@@ -13,8 +13,9 @@
   * Intel 631xESB/632xESB (ESB2)
   * Intel 82801H (ICH8)
   * Intel 82801I (ICH9)
-  * Intel Tolapai
-  * Intel ICH10
+  * Intel EP80579 (Tolapai)
+  * Intel 82801JI (ICH10)
+  * Intel PCH
    Datasheets: Publicly available at the Intel website
 
 Authors: 

@@ -32,7 +33,7 @@
 -----------
 
 The ICH (properly known as the 82801AA), ICH0 (82801AB), ICH2 (82801BA),
-ICH3 (82801CA/CAM) and later devices are Intel chips that are a part of
+ICH3 (82801CA/CAM) and later devices (PCH) are Intel chips that are a part of
 Intel's '810' chipset for Celeron-based PCs, '810E' chipset for
 Pentium-based PCs, '815E' chipset, and others.
drivers/i2c/busses/i2c-i801.c renamed from drivers/i2c/busses/i2c-i801.c.orig +2 -0
@@ -577,6 +577,7 @@
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TOLAPAI_1) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_4) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10_5) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_PCH_SMBUS) },
 	{ 0, }
 };
 

@@ -600,6 +601,7 @@
 	case PCI_DEVICE_ID_INTEL_TOLAPAI_1:
 	case PCI_DEVICE_ID_INTEL_ICH10_4:
 	case PCI_DEVICE_ID_INTEL_ICH10_5:
+	case PCI_DEVICE_ID_INTEL_PCH_SMBUS:
 		i801_features |= FEATURE_I2C_BLOCK_READ;
 		/* fall through */
 	case PCI_DEVICE_ID_INTEL_82801DB_3:

drivers/i2c/busses/Kconfig line 103

Quoted 7 lines
drivers/i2c/busses/Kconfig renamed from drivers/i2c/busses/Kconfig.orig +1 -0
@@ -97,6 +97,7 @@
 	    ICH9
 	    Tolapai
 	    ICH10
+	    PCH
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called i2c-i801.

Thanks,

Signature · 1 line
Jean Delvare