OMAP2xxx EAC build fix and sparse cleanup
cover OMAP2xxx EAC build fix and sparse cleanup
This series fixes a build bug in the EAC driver after the recent IO address changes, and resolves some sparse warnings.
Compile-tested only.
---
sound/arm/omap/eac.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
PATCH 1/2 OMAP2xxx EAC: update per recent IO address changes
Commit f228a725b975832ac5771ab2fc86d06bd694cdb3 breaks the build for this driver; fix by using OMAP2_IO_ADDRESS.
--- sound/arm/omap/eac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
sound/arm/omap/eac.c +1 -1
@@ -707,7 +707,7 @@ static int __devinit eac_probe(struct platform_device *pdev) err = -ENODEV ; goto err1; } - eac->base = (void __iomem *)io_p2v (res->start); + eac->base =OMAP2_IO_ADDRESS (res->start); eac->pdata = pdata;/* pre-initialize EAC hw */
Re: [PATCH 1/2] OMAP2xxx EAC: update per recent IO address changes
Quoted 2 lines · Paul Walmsley
Commit
f228a725b975832ac5771ab2fc86d06bd694cdb3breaks the build for this driver; fix by usingOMAP2_IO_ADDRESS.
Hmmm. I should be using ioremap(). New version coming.
- Paul
PATCH 2/2 OMAP2xxx EAC: fix sparse warnings
In reply to Paul WalmsleyThis patch resolves the following two sparse warnings:
sound/arm/omap/eac.c:788:12: warning: symbol 'eac_init' was not declared. Should it be static? sound/arm/omap/eac.c:793:13: warning: symbol 'eac_exit' was not declared. Should it be static?
--- sound/arm/omap/eac.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
sound/arm/omap/eac.c +2 -2
@@ -785,12 +785,12 @@ static struct platform_driver eac_driver = { .remove = eac_remove, }; -int __init eac_init (void ) +static int __init eac_init (void ) {return platform_driver_register (&eac_driver); } -void __exit eac_exit(void) +static void __exit eac_exit(void) {platform_driver_unregister (&eac_driver); }