UIO: Resend: Change driver name of uio_pdrv
PATCH 1/1 UIO: Resend: Change driver name of uio_pdrv
The patch below was already discussed and accepted:
http://lkml.org/lkml/2008/7/7/409
It somehow got lost (probably because I forgot it when I sent my queue to Greg...). So, here it is again:
-------------8<------------------------
The generic UIO platform device driver should be given a unique driver ID and not just "uio". This is especially important since we now have a similar driver named uio_pdrv_genirq. Currently, there's no user of this driver in the mainline kernel.
--- drivers/uio/uio_pdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/uio/uio_pdrv.c +1 -1
@@ -12,7 +12,7 @@#include <linux/uio_driver.h> #include <linux/stringify.h> -#define DRIVER_NAME "uio" +#define DRIVER_NAME "uio_pdrv"struct uio_platdata {struct uio_info *uioinfo;
Hello Hans,
[Added Magnus Damm (= author of uio_pdrv_genirq) to Cc:]
Quoted 6 lines · Hans J. Koch
The patch below was already discussed and accepted:
http://lkml.org/lkml/2008/7/7/409It somehow got lost (probably because I forgot it when I sent my queue to Greg...). So, here it is again:
Quoted 6 lines
-------------8<------------------------
The generic UIO platform device driver should be given a unique driver ID and not just "uio". This is especially important since we now have a similar driver named
uio_pdrv_genirq. Currently, there's no user of this driver in the mainline kernel.
I want to suggest to rename uio_pdrv_genirq to uio_genirq instead. In my eyes this would be more clear. IMHO the pdrv suffix doesn't yield more clearity because it is only used in a certain namespace---namely that of platform devices. So e.g.
/sys/bus/platform/devices/uio_pdrv.0
isn't any better than
/sys/bus/platform/devices/uio.0
. Looking at the name of other platform drivers using
git grep -E '_pdrv(_.*)?"'
I get three false positives[1] and uio_pdrv_genirq (driver and some users in arch/sh/kernel/cpu/sh4a/setup-sh7343.c). So the _pdrv suffix doesn't seem very common.
Just my 0.02€
Best regards
Uwe
[1] in drivers/scsi/megaraid.c
Quoted 22 lines · Uwe Kleine-König
Hello Hans,
[Added Magnus Damm (= author of
uio_pdrv_genirq) to Cc:]Quoted 6 lines · Hans J. Koch
The patch below was already discussed and accepted:
http://lkml.org/lkml/2008/7/7/409It somehow got lost (probably because I forgot it when I sent my queue to Greg...). So, here it is again:
Quoted 6 lines
-------------8<------------------------
The generic UIO platform device driver should be given a unique driver ID and not just "uio". This is especially important since we now have a similar driver named
uio_pdrv_genirq. Currently, there's no user of this driver in the mainline kernel.I want to suggest to rename
uio_pdrv_genirqtouio_genirqinstead. In my eyes this would be more clear. IMHO the pdrv suffix doesn't yield more clearity because it is only used in a certain namespace---namely that of platform devices. So e.g.
Quoted 5 lines
/sys/bus/platform/devices/uio_pdrv.0isn't any better than
/sys/bus/platform/devices/uio.0
Well, I just want to avoid using the generic "uio" identifier for a single driver. A sysfs entry like this last one looks like a kind of "standard way" how a UIO platform device driver should be done. I'd like to avoid that impression. It can be "uio_pdrv" or "uio_pdrv_genirq", but there's no standard "uio" way of handling platform devices.
Quoted 8 lines
. Looking at the name of other platform drivers using
git grep -E '_pdrv(_.*)?"'I get three false positives[1] and
uio_pdrv_genirq(driver and some users inarch/sh/kernel/cpu/sh4a/setup-sh7343.c). So the_pdrvsuffix doesn't seem very common.
I don't really understand what you mean here.
Quoted 2 lines
Just my 0.02€
Thanks,
Hans
Hello,
Quoted 4 lines · Hans J. Koch
Quoted 3 lines · Uwe Kleine-König
Hello Hans,
[Added Magnus Damm (= author of
uio_pdrv_genirq) to Cc:]
Note: Magnus' address seems to be wrong. I don't know a working one.
Quoted 11 lines
Quoted 11 lines
Quoted 4 lines
The generic UIO platform device driver should be given a unique driver ID and not just "uio". This is especially important since we now have a similar driver named
uio_pdrv_genirq. Currently, there's no user of this driver in the mainline kernel.I want to suggest to rename
uio_pdrv_genirqtouio_genirqinstead. In my eyes this would be more clear. IMHO the pdrv suffix doesn't yield more clearity because it is only used in a certain namespace---namely that of platform devices. So e.g.
/sys/bus/platform/devices/uio_pdrv.0
Quoted 7 lines
Quoted 3 lines
isn't any better than
/sys/bus/platform/devices/uio.0Well, I just want to avoid using the generic "uio" identifier for a single driver. A sysfs entry like this last one looks like a kind of "standard way" how a UIO platform device driver should be done.
I wonder that you don't have this impression with "uio_pdrv".
Quoted 3 lines
I'd like
to avoid that impression. It can be "uio_pdrv" or "uio_pdrv_genirq", but there's no standard "uio" way of handling platform devices.
I thought the driver in discussion is kind of a standard way to create a platform driver using uio.
(At least you called it "generic UIO platform device driver" above :-)
Quoted 10 lines
Quoted 8 lines
. Looking at the name of other platform drivers using
git grep -E '_pdrv(_.*)?"'I get three false positives[1] and
uio_pdrv_genirq(driver and some users inarch/sh/kernel/cpu/sh4a/setup-sh7343.c). So the_pdrvsuffix doesn't seem very common.I don't really understand what you mean here.
I tried to point out that uio_pdrv_genirq is (probably) the only platform driver that has _pdrv in its name.
Best regards
Uwe
[email protected]
Appliedpatch uio-change-driver-name-of-uio_pdrv.patch added to gregkh-2.6 tree
In reply to Hans J. KochThis is a note to let you know that I've just added the patch titled
Subject: UIO: Change driver name of uio_pdrv
to my gregkh-2.6 tree. Its filename is
uio-change-driver-name-of-uio_pdrv.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
Quoted 1 line
From [email protected] Tue Sep 23 15:59:56 2008
From: "Hans J. Koch" <[email protected]>
Date: Thu, 18 Sep 2008 23:03:07 +0200
Subject: UIO: Change driver name of uio_pdrv
To: Greg KH <[email protected]>
Cc: Uwe Kleine-K�nig <[email protected]>, LKML <[email protected]>
Message-ID: <20080918210306.GC2991@local>
Content-Disposition: inline
The generic UIO platform device driver should be given a unique driver ID and not just "uio". This is especially important since we now have a similar driver named uio_pdrv_genirq. Currently, there's no user of this driver in the mainline kernel.
--- drivers/uio/uio_pdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/uio/uio_pdrv.c +1 -1
@@ -12,7 +12,7 @@#include <linux/uio_driver.h> #include <linux/stringify.h> -#define DRIVER_NAME "uio" +#define DRIVER_NAME "uio_pdrv"struct uio_platdata {struct uio_info *uioinfo;
Patches currently in gregkh-2.6 which might be from [email protected] are
bad/uio-irq.patch driver-core/uio-add-alignment-warnings-for-uio-mem.patch driver-core/uio-add-automata-sercos3-pci-card-support.patch driver-core/uio-change-driver-name-of-uio_pdrv.patch