Skip to contentSkip to conversation

add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)

PATCH In review Neil Horman 3 participants 6 messages Oct 9, 2008 – Oct 20, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)

Hey-
The makdumpdile dump filtering program, in some modes of operation needs
the node_data and/or contig_page_data symbols to function properly. These symbols are missing from the powerpc kernel. This patch adds those symbols in properly. Tested successfully by myself and the reporter.

Regards
Neil

 machine_kexec.c |   10 ++++++++++
 1 file changed, 10 insertions(+)
arch/powerpc/kernel/machine_kexec.c +10 -0
index aab7688..2f9b5aa 100644
@@ -44,6 +44,16 @@ void machine_kexec_cleanup(struct kimage *image)
 		ppc_md.machine_kexec_cleanup(image);
 }
 
+void arch_crash_save_vmcoreinfo(void)
+{
+#ifdef CONFIG_NEED_MULTIPLE_NODES
+	VMCOREINFO_SYMBOL(node_data);
+	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
+#else
+	VMCOREINFO_SYMBOL(contig_page_data);
+#endif
+}
+
 /*
  * Do not allocate memory (or fail in any way) in machine_kexec().
  * We are past the point of no return, committed to rebooting now.
Signature · 11 lines
/***************************************************
 *Neil Horman
 *[email protected]
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Reviewed-by on v1 1/1
#1 lore raw

Hi Neil,

I had created similar patch, but your patch is better than mine because your patch has right configuration dependency. So I think this patch is fine.

Thanks
Ken'ichi Ohmichi

* Reference:
http://lists.infradead.org/pipermail/kexec/2008-June/001970.html

Quoted 27 lines · Neil Horman

Hey-
The makdumpdile dump filtering program, in some modes of operation needs
the node_data and/or contig_page_data symbols to function properly. These symbols are missing from the powerpc kernel. This patch adds those symbols in properly. Tested successfully by myself and the reporter.

Regards
Neil

 machine_kexec.c |   10 ++++++++++
 1 file changed, 10 insertions(+)
arch/powerpc/kernel/machine_kexec.c +3 -0
index aab7688..2f9b5aa 100644
@@ -44,6 +44,16 @@ void machine_kexec_cleanup(struct kimage *image)
 		ppc_md.machine_kexec_cleanup(image);
 }
 
+void arch_crash_save_vmcoreinfo(void)
+{
+#ifdef CONFIG_NEED_MULTIPLE_NODES

arch/powerpc/kernel/machine_kexec.c void machine_kexec_cleanup(struct kimage *image) · line 59

Quoted 10 lines
arch/powerpc/kernel/machine_kexec.c +7 -0
+	VMCOREINFO_SYMBOL(node_data);
+	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
+#else
+	VMCOREINFO_SYMBOL(contig_page_data);
+#endif
+}
+
 /*
  * Do not allocate memory (or fail in any way) in machine_kexec().
  * We are past the point of no return, committed to rebooting now.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#2 lore raw
In reply to Neil Horman
Quoted 24 lines · Neil Horman

Hey-
The makdumpdile dump filtering program, in some modes of operation needs
the node_data and/or contig_page_data symbols to function properly. These symbols are missing from the powerpc kernel. This patch adds those symbols in properly. Tested successfully by myself and the reporter.

Regards
Neil

 machine_kexec.c |   10 ++++++++++
 1 file changed, 10 insertions(+)
arch/powerpc/kernel/machine_kexec.c +0 -0
index aab7688..2f9b5aa 100644
@@ -44,6 +44,16 @@ void machine_kexec_cleanup(struct kimage *image)
 		ppc_md.machine_kexec_cleanup(image);
 }
 

arch/powerpc/kernel/machine_kexec.c void machine_kexec_cleanup(struct kimage *image) · line 56

Quoted 10 lines
arch/powerpc/kernel/machine_kexec.c +10 -0
+void arch_crash_save_vmcoreinfo(void)
+{
+#ifdef CONFIG_NEED_MULTIPLE_NODES
+	VMCOREINFO_SYMBOL(node_data);
+	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
+#else
+	VMCOREINFO_SYMBOL(contig_page_data);
+#endif
+}
+

Hi Neil,

Looks like contig_page_data is already being saved in arch independent portion of kexec (crash_save_vmcoreinfo_init()). We probably don't need to save it here again?

#ifndef CONFIG_NEED_MULTIPLE_NODES
        VMCOREINFO_SYMBOL(mem_map);
        VMCOREINFO_SYMBOL(contig_page_data);

#endif

Thanks
Vivek

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#3 lore raw
Quoted 42 lines · Vivek Goyal
Quoted 24 lines · Neil Horman

Hey-
The makdumpdile dump filtering program, in some modes of operation needs
the node_data and/or contig_page_data symbols to function properly. These symbols are missing from the powerpc kernel. This patch adds those symbols in properly. Tested successfully by myself and the reporter.

Regards
Neil

 machine_kexec.c |   10 ++++++++++
 1 file changed, 10 insertions(+)
arch/powerpc/kernel/machine_kexec.c +0 -0
index aab7688..2f9b5aa 100644
@@ -44,6 +44,16 @@ void machine_kexec_cleanup(struct kimage *image)
 		ppc_md.machine_kexec_cleanup(image);
 }
 

arch/powerpc/kernel/machine_kexec.c void machine_kexec_cleanup(struct kimage *image) · line 56

Quoted 10 lines
arch/powerpc/kernel/machine_kexec.c +10 -0
+void arch_crash_save_vmcoreinfo(void)
+{
+#ifdef CONFIG_NEED_MULTIPLE_NODES
+	VMCOREINFO_SYMBOL(node_data);
+	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
+#else
+	VMCOREINFO_SYMBOL(contig_page_data);
+#endif
+}
+

Hi Neil,

Looks like contig_page_data is already being saved in arch independent portion of kexec (crash_save_vmcoreinfo_init()). We probably don't need to save it here again?

Quoted 8 lines
#ifndef CONFIG_NEED_MULTIPLE_NODES
        VMCOREINFO_SYMBOL(mem_map);
        VMCOREINFO_SYMBOL(contig_page_data);

#endif

Thanks
Vivek

Oops your right. I fixed that in RHEL and must not have searched for it upstream. I'll repost a corrected patch monday.
Thanks!
Neil

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#4 lore raw
In reply to Vivek Goyal

Hey Vivek, as promised, a corrected patch

The makdumpdile dump filtering program, in some modes of operation needs
the node_data and/or contig_page_data symbols to function properly. These symbols are missing from the powerpc kernel. This patch adds those symbols in properly. Tested successfully by myself and the reporter.

Regards
Neil

 machine_kexec.c |    8 ++++++++
 1 file changed, 8 insertions(+)
arch/powerpc/kernel/machine_kexec.c +8 -0
index aab7688..5d51e75 100644
@@ -44,6 +44,14 @@ void machine_kexec_cleanup(struct kimage *image)
 		ppc_md.machine_kexec_cleanup(image);
 }
 
+void arch_crash_save_vmcoreinfo(void)
+{
+#ifdef CONFIG_NEED_MULTIPLE_NODES
+	VMCOREINFO_SYMBOL(node_data);
+	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
+#endif
+}
+
 /*
  * Do not allocate memory (or fail in any way) in machine_kexec().
  * We are past the point of no return, committed to rebooting now.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Acked-by
#5 lore raw
Quoted 23 lines · Neil Horman

Hey Vivek, as promised, a corrected patch

The makdumpdile dump filtering program, in some modes of operation needs
the node_data and/or contig_page_data symbols to function properly. These symbols are missing from the powerpc kernel. This patch adds those symbols in properly. Tested successfully by myself and the reporter.

Regards
Neil

 machine_kexec.c |    8 ++++++++
 1 file changed, 8 insertions(+)
arch/powerpc/kernel/machine_kexec.c +0 -0
index aab7688..5d51e75 100644
@@ -44,6 +44,14 @@ void machine_kexec_cleanup(struct kimage *image)
 		ppc_md.machine_kexec_cleanup(image);

arch/powerpc/kernel/machine_kexec.c void machine_kexec_cleanup(struct kimage *image) · line 54

Quoted 10 lines
arch/powerpc/kernel/machine_kexec.c +8 -0
 }
 
+void arch_crash_save_vmcoreinfo(void)
+{
+#ifdef CONFIG_NEED_MULTIPLE_NODES
+	VMCOREINFO_SYMBOL(node_data);
+	VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
+#endif
+}
+

Looks good to me.

Thanks
Vivek

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec