Skip to contentSkip to conversation

USB: remove info() macro from usb mtd drivers

PATCH In review Greg KH 2 participants 3 messages Oct 10, 2008

Subsystems (2)
lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 USB: remove info() macro from usb mtd drivers

From: Greg Kroah-Hartman <[email protected]>

USB should not be having it's own printk macros, so remove info() and use the system-wide standard of dev_info() wherever possible.

---
David, this has been in the USB tree for a few months now, sorry for not sending it to you sooner. I can easily keep it in my tree and send it to Linus for this merge if you want me to, or you can take it in your tree, which ever you want me to do.

thanks,

greg k-h

 drivers/mtd/nand/alauda.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/nand/alauda.c +2 -2
@@ -691,7 +691,7 @@ static int alauda_probe(struct usb_inter
 	al[0].port = ALAUDA_PORT_XD;
 	al[1].port = ALAUDA_PORT_SM;
 
-	info("alauda probed");
+	dev_info(&interface->dev, "alauda probed\n");
 	alauda_check_media(al);
 	alauda_check_media(al+1);
 
@@ -716,7 +716,7 @@ static void alauda_disconnect(struct usb
 	if (al)
 		kref_put(&al->kref, alauda_delete);
 
-	info("alauda gone");
+	dev_info(&interface->dev, "alauda gone");
 }
 
 static struct usb_driver alauda_driver = {
#1 lore raw
Quoted 5 lines · Greg KH

From: Greg Kroah-Hartman <[email protected]>

USB should not be having it's own printk macros, so remove info() and use the system-wide standard of dev_info() wherever possible.

Quoted 7 lines

---
David, this has been in the USB tree for a few months now, sorry for not sending it to you sooner. I can easily keep it in my tree and send it to Linus for this merge if you want me to, or you can take it in your tree, which ever you want me to do.

Since you already seem to have it, you might as well keep it. Thanks.

Signature · 2 lines
David Woodhouse                            Open Source Technology Centre
[email protected]                              Intel Corporation
author
#2 lore raw
Quoted 14 lines · David Woodhouse
Quoted 5 lines · Greg KH

From: Greg Kroah-Hartman <[email protected]>

USB should not be having it's own printk macros, so remove info() and use the system-wide standard of dev_info() wherever possible.

Quoted 7 lines

---
David, this has been in the USB tree for a few months now, sorry for not sending it to you sooner. I can easily keep it in my tree and send it to Linus for this merge if you want me to, or you can take it in your tree, which ever you want me to do.

Quoted 1 line

Since you already seem to have it, you might as well keep it. Thanks.

Great, will do, thanks.

greg k-h