sparc64 allmodconfig build failure...
Subsystems (4)
sparc64 allmodconfig started failing to build recently:
MODPOST 1946 modules
ERROR: "cpufreq_gov_performance" [arch/sparc64/kernel/us3_cpufreq.ko] undefined!
It seems to be caused by the following commit:
commit c4d14bc0bb5d13e316890651ae4518b764c3344c
Author: Sven Wegener <[email protected]> Date: Sat Sep 20 16:50:08 2008 +0200
[CPUFREQ] Don't export governors for default governor
We don't need to export the governors for use as the default governor, because the default governor will be built-in anyway and we can access the symbol directly.
This also fixes the following sparse warnings:
drivers/cpufreq/cpufreq_conservative.c:578:25: warning: symbol 'cpufreq_gov_conservative' was not declared. Should it be static? drivers/cpufreq/cpufreq_ondemand.c:582:25: warning: symbol 'cpufreq_gov_ondemand' was not declared. Should it be static? drivers/cpufreq/cpufreq_performance.c:39:25: warning: symbol 'cpufreq_gov_performance' was not declared. Should it be static? drivers/cpufreq/cpufreq_powersave.c:38:25: warning: symbol 'cpufreq_gov_powersave' was not declared. Should it be static? drivers/cpufreq/cpufreq_userspace.c:190:25: warning: symbol 'cpufreq_gov_userspace' was not declared. Should it be static?
drivers/cpufreq/cpufreq_conservative.c +3 -1
@@ -576,13 +576,15 @@ static int cpufreq_governor_dbs(struct cpufreq_policy *policy,return 0 ; } +#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE +static +#endif struct cpufreq_governor cpufreq_gov_conservative = { .name ="conservative" , .governor = cpufreq_governor_dbs, .max_transition_latency =TRANSITION_LATENCY_LIMIT , .owner =THIS_MODULE , }; -EXPORT_SYMBOL (cpufreq_gov_conservative);static int __init cpufreq_gov_dbs_init (void ) {
drivers/cpufreq/cpufreq_ondemand.c +3 -1
@@ -626,13 +626,15 @@ static int cpufreq_governor_dbs(struct cpufreq_policy *policy,return 0 ; } +#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND +static +#endif struct cpufreq_governor cpufreq_gov_ondemand = { .name ="ondemand" , .governor = cpufreq_governor_dbs, .max_transition_latency =TRANSITION_LATENCY_LIMIT , .owner =THIS_MODULE , }; -EXPORT_SYMBOL (cpufreq_gov_ondemand);static int __init cpufreq_gov_dbs_init (void ) {
drivers/cpufreq/cpufreq_performance.c +3 -1
@@ -36,12 +36,14 @@ static int cpufreq_governor_performance(struct cpufreq_policy *policy,return 0 ; } +#ifdef CONFIG_CPU_FREQ_GOV_PERFORMANCE_MODULE +static +#endif struct cpufreq_governor cpufreq_gov_performance = { .name ="performance" , .governor = cpufreq_governor_performance, .owner =THIS_MODULE , }; -EXPORT_SYMBOL (cpufreq_gov_performance);static int __init cpufreq_gov_performance_init (void )
drivers/cpufreq/cpufreq_powersave.c +3 -1
@@ -35,12 +35,14 @@ static int cpufreq_governor_powersave(struct cpufreq_policy *policy,return 0 ; } +#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE +static +#endif struct cpufreq_governor cpufreq_gov_powersave = { .name ="powersave" , .governor = cpufreq_governor_powersave, .owner =THIS_MODULE , }; -EXPORT_SYMBOL (cpufreq_gov_powersave);static int __init cpufreq_gov_powersave_init (void ) {
drivers/cpufreq/cpufreq_userspace.c +3 -1
@@ -187,6 +187,9 @@ static int cpufreq_governor_userspace(struct cpufreq_policy *policy, } +#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE +static +#endif struct cpufreq_governor cpufreq_gov_userspace = { .name ="userspace" , .governor = cpufreq_governor_userspace,
@@ -194,7 +197,6 @@ struct cpufreq_governor cpufreq_gov_userspace = { .show_setspeed = show_speed, .owner = THIS_MODULE, }; -EXPORT_SYMBOL (cpufreq_gov_userspace);static int __init cpufreq_gov_userspace_init (void ) {
Quoted 8 lines · David Miller
sparc64 allmodconfig started failing to build recently:
MODPOST 1946 modules
ERROR: "cpufreq_gov_performance" [arch/sparc64/kernel/us3_cpufreq.ko] undefined!It seems to be caused by the following commit:
commit
c4d14bc0bb5d13e316890651ae4518b764c3344c
Quoted 8 lines
Author: Sven Wegener <[email protected]> Date: Sat Sep 20 16:50:08 2008 +0200[CPUFREQ] Don't export governors for default governor
We don't need to export the governors for use as the default governor, because the default governor will be built-in anyway and we can access the symbol directly.
Uhm, we could resolve this dependency with the patch below. Although we might as well revert the above commit or introduce an exported function that sets the default governor on a policy.
Subject: [CPUFREQ] Fix build failure on sparc64
Commit c4d14bc0bb5d13e316890651ae4518b764c3344c ("[CPUFREQ] Don't export governors for default governor") caused a build failure, because there are several architectures that have cpufreq code that can be built as a module, but the code also requires access to the default governor. Export the default governor so that it can be accessed by these module.
--- drivers/cpufreq/cpufreq_conservative.c | 4 +++- drivers/cpufreq/cpufreq_ondemand.c | 4 +++- drivers/cpufreq/cpufreq_performance.c | 4 +++- drivers/cpufreq/cpufreq_powersave.c | 4 +++- drivers/cpufreq/cpufreq_userspace.c | 4 +++- 5 files changed, 15 insertions(+), 5 deletions(-)
drivers/cpufreq/cpufreq_conservative.c +3 -1
@@ -576,7 +576,9 @@ static int cpufreq_governor_dbs(struct cpufreq_policy *policy,return 0 ; } -#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE +#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE +EXPORT_SYMBOL (cpufreq_gov_conservative); +#else static#endif struct cpufreq_governor cpufreq_gov_conservative = {
drivers/cpufreq/cpufreq_ondemand.c +3 -1
@@ -626,7 +626,9 @@ static int cpufreq_governor_dbs(struct cpufreq_policy *policy,return 0 ; } -#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND +#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND +EXPORT_SYMBOL (cpufreq_gov_ondemand); +#else static#endif struct cpufreq_governor cpufreq_gov_ondemand = {
drivers/cpufreq/cpufreq_performance.c +3 -1
@@ -36,7 +36,9 @@ static int cpufreq_governor_performance(struct cpufreq_policy *policy,return 0 ; } -#ifdef CONFIG_CPU_FREQ_GOV_PERFORMANCE_MODULE +#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE +EXPORT_SYMBOL (cpufreq_gov_performance); +#elif defined(CONFIG_CPU_FREQ_GOV_PERFORMANCE_MODULE ) static#endif struct cpufreq_governor cpufreq_gov_performance = {
drivers/cpufreq/cpufreq_powersave.c +3 -1
@@ -35,7 +35,9 @@ static int cpufreq_governor_powersave(struct cpufreq_policy *policy,return 0 ; } -#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE +#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE +EXPORT_SYMBOL (cpufreq_gov_powersave); +#else static#endif struct cpufreq_governor cpufreq_gov_powersave = {
drivers/cpufreq/cpufreq_userspace.c +3 -1
@@ -187,7 +187,9 @@ static int cpufreq_governor_userspace(struct cpufreq_policy *policy, } -#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE +#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE +EXPORT_SYMBOL (cpufreq_gov_userspace); +#else static#endif struct cpufreq_governor cpufreq_gov_userspace = {
Quoted 34 lines · Sven Wegener
Quoted 8 lines · David Miller
sparc64 allmodconfig started failing to build recently:
MODPOST 1946 modules
ERROR: "cpufreq_gov_performance" [arch/sparc64/kernel/us3_cpufreq.ko] undefined!It seems to be caused by the following commit:
commit
c4d14bc0bb5d13e316890651ae4518b764c3344cQuoted 8 lines
Author: Sven Wegener <[email protected]> Date: Sat Sep 20 16:50:08 2008 +0200[CPUFREQ] Don't export governors for default governor
We don't need to export the governors for use as the default governor, because the default governor will be built-in anyway and we can access the symbol directly.
Uhm, we could resolve this dependency with the patch below. Although we might as well revert the above commit or introduce an exported function that sets the default governor on a policy.
Subject: [CPUFREQ] Fix build failure on sparc64
Commit
c4d14bc0bb5d13e316890651ae4518b764c3344c("[CPUFREQ] Don't export governors for default governor") caused a build failure, because there are several architectures that have cpufreq code that can be built as a module, but the code also requires access to the default governor. Export the default governor so that it can be accessed by these module.
drivers/cpufreq/cpufreq_conservative.c static int cpufreq_governor_dbs(struct cpufreq_policy *policy, · line 583
Quoted 9 lines
drivers/cpufreq/cpufreq_conservative.c +3
-1@@ -576,7 +576,9 @@ static int cpufreq_governor_dbs(struct cpufreq_policy *policy,return 0 ; } -#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE +#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE +EXPORT_SYMBOL (cpufreq_gov_conservative); +#else static#endif
This is ugly, ugly.
Quoted 38 lines · Alexey Dobriyan
Quoted 37 lines · Sven Wegener
Quoted 8 lines · David Miller
sparc64 allmodconfig started failing to build recently:
MODPOST 1946 modules
ERROR: "cpufreq_gov_performance" [arch/sparc64/kernel/us3_cpufreq.ko] undefined!It seems to be caused by the following commit:
commit
c4d14bc0bb5d13e316890651ae4518b764c3344cQuoted 8 lines
Author: Sven Wegener <[email protected]> Date: Sat Sep 20 16:50:08 2008 +0200[CPUFREQ] Don't export governors for default governor
We don't need to export the governors for use as the default governor, because the default governor will be built-in anyway and we can access the symbol directly.
Uhm, we could resolve this dependency with the patch below. Although we might as well revert the above commit or introduce an exported function that sets the default governor on a policy.
Subject: [CPUFREQ] Fix build failure on sparc64
Commit
c4d14bc0bb5d13e316890651ae4518b764c3344c("[CPUFREQ] Don't export governors for default governor") caused a build failure, because there are several architectures that have cpufreq code that can be built as a module, but the code also requires access to the default governor. Export the default governor so that it can be accessed by these module.drivers/cpufreq/cpufreq_conservative.c +0
-0@@ -576,7 +576,9 @@ static int cpufreq_governor_dbs(struct cpufreq_policy *policy,return 0 ; }
Quoted 8 lines
drivers/cpufreq/cpufreq_conservative.c static int cpufreq_governor_dbs(struct cpufreq_policy *policy, · line 583
Quoted 6 lines
drivers/cpufreq/cpufreq_conservative.c +3
-1-#ifndef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE +#ifdef CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE +EXPORT_SYMBOL (cpufreq_gov_conservative); +#else static#endif This is ugly, ugly.
Yeah, with the default governor being any of supported governors, we either need some ugly #ifdef mess to only export the governor that is selected or just revert to the old code, which unconditionally exports all governors. Or something like the patch below. With the additional modules that I oversaw and that require the export, I'm fine with just reverting the commit, although I think that encapsulating the default governor decision in a built-in function is cleaner than having modules reference different symbols depending on configuration.
Subject: [CPUFREQ] Fix build failure on sparc64
Commit c4d14bc0bb5d13e316890651ae4518b764c3344c ("[CPUFREQ] Don't export governors for default governor") caused a build failure, because there are several architectures that have cpufreq code that can be built as a module, but the code also requires access to the default governor. Instead of messing around with even more #ifdef code, add an exported function that sets the default governor on a policy.
arch/arm/mach-integrator/cpu.c +1 -1
@@ -184,7 +184,7 @@ static int integrator_cpufreq_init(struct cpufreq_policy *policy) {/* set default policy and cpuinfo */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +cpufreq_policy_set_default_governor (policy); policy->cpuinfo.max_freq =160000 ; policy->cpuinfo.min_freq =12000 ; policy->cpuinfo.transition_latency =1000000 ;/* 1 ms, assumed */
arch/arm/mach-pxa/cpufreq-pxa2xx.c +1 -1
@@ -335,7 +335,7 @@ static __init int pxa_cpufreq_init(struct cpufreq_policy *policy)pxa27x_guess_max_freq ();/* set default policy and cpuinfo */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +cpufreq_policy_set_default_governor (policy);if (cpu_is_pxa25x ()) policy->policy =CPUFREQ_POLICY_PERFORMANCE ; policy->cpuinfo.transition_latency =1000 ;/* FIXME: 1 ms, assumed */
arch/arm/mach-pxa/cpufreq-pxa3xx.c +1 -1
@@ -210,7 +210,7 @@ static __init int pxa3xx_cpufreq_init(struct cpufreq_policy *policy)int ret = -EINVAL ;/* set default policy and cpuinfo */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +cpufreq_policy_set_default_governor (policy); policy->cpuinfo.min_freq =104000 ; policy->cpuinfo.max_freq = (cpu_is_pxa320 ()) ?806000 :624000 ; policy->cpuinfo.transition_latency =1000 ;/* FIXME: 1 ms, assumed */
arch/arm/mach-sa1100/cpu-sa1100.c +1 -1
@@ -224,7 +224,7 @@ static int __init sa1100_cpu_init(struct cpufreq_policy *policy)if (policy->cpu !=0 )return -EINVAL ; policy->cur = policy->min = policy->max =sa11x0_getspeed (0 ); - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +cpufreq_policy_set_default_governor (policy); policy->cpuinfo.min_freq =59000 ; policy->cpuinfo.max_freq =287000 ; policy->cpuinfo.transition_latency =CPUFREQ_ETERNAL ;
arch/avr32/mach-at32ap/cpufreq.c +1 -1
@@ -87,7 +87,7 @@ static int __init at32_cpufreq_driver_init(struct cpufreq_policy *policy) policy->cur =at32_get_speed (0 ); policy->min = policy->cpuinfo.min_freq; policy->max = policy->cpuinfo.max_freq; - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +cpufreq_policy_set_default_governor (policy);printk ("cpufreq: AT32AP CPU frequency driver\n" );
arch/blackfin/mach-common/cpufreq.c +1 -1
@@ -158,7 +158,7 @@ static int __init __bfin_cpu_init(struct cpufreq_policy *policy) dpm_state_table[index].tscale); } - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +cpufreq_policy_set_default_governor (policy); policy->cpuinfo.transition_latency = (bfin_read_PLL_LOCKCNT () / (sclk /1000000 )) *1000 ;/*Now ,only support one cpu */
arch/cris/arch-v32/mach-a3/cpufreq.c +1 -1
@@ -85,7 +85,7 @@ static int cris_freq_cpu_init(struct cpufreq_policy *policy)int result;/* cpuinfo and default policy values */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +cpufreq_policy_set_default_governor (policy); policy->cpuinfo.transition_latency =1000000 ;/* 1ms */ policy->cur =cris_freq_get_cpu_frequency (0 );
arch/cris/arch-v32/mach-fs/cpufreq.c +1 -1
@@ -81,7 +81,7 @@ static int cris_freq_cpu_init(struct cpufreq_policy *policy)int result;/* cpuinfo and default policy values */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +cpufreq_policy_set_default_governor (policy); policy->cpuinfo.transition_latency =1000000 ;/* 1ms */ policy->cur =cris_freq_get_cpu_frequency (0 );
arch/sparc64/kernel/us3_cpufreq.c +1 -1
@@ -183,7 +183,7 @@ static int __init us3_freq_cpu_init(struct cpufreq_policy *policy) table[3 ].index =0 ; table[3 ].frequency =CPUFREQ_TABLE_END ; - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +cpufreq_policy_set_default_governor (policy); policy->cpuinfo.transition_latency =0 ; policy->cur = clock_tick;
drivers/cpufreq/cpufreq.c +6 -1
@@ -813,7 +813,7 @@ static int cpufreq_add_dev(struct sys_device *sys_dev)INIT_WORK (&policy->update, handle_update);/* Set governor before ->init, so that driver could check it */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +cpufreq_policy_set_default_governor (policy);/* call driver. From then on the cpufreq must be able * to accept all calls to ->verify and ->setpolicy for this CPU */
@@ -1554,6 +1554,11 @@ static int __cpufreq_governor(struct cpufreq_policy *policy,return ret; } +void cpufreq_policy_set_default_governor (struct cpufreq_policy *policy) +{ + policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; +} +EXPORT_SYMBOL_GPL (cpufreq_policy_set_default_governor);int cpufreq_register_governor (struct cpufreq_governor *governor) {
include/linux/cpufreq.h +1 -0
@@ -190,6 +190,7 @@ extern int __cpufreq_driver_target(struct cpufreq_policy *policy,extern int __cpufreq_driver_getavg (struct cpufreq_policy *policy,unsigned int cpu); +void cpufreq_policy_set_default_governor (struct cpufreq_policy *policy);int cpufreq_register_governor (struct cpufreq_governor *governor);void cpufreq_unregister_governor (struct cpufreq_governor *governor);
From: Sven Wegener <[email protected]>
Date: Tue, 14 Oct 2008 23:08:17 +0200 (CEST)
Quoted 9 lines
Yeah, with the default governor being any of supported governors, we either need some ugly #ifdef mess to only export the governor that is selected or just revert to the old code, which unconditionally exports all governors. Or something like the patch below. With the additional modules that I oversaw and that require the export, I'm fine with just reverting the commit, although I think that encapsulating the default governor decision in a built-in function is cleaner than having modules reference different symbols depending on configuration.
Personally I prefer the revert.
All of the alternative solutions shown far have been extremely ugly.
Quoted 13 lines · David Miller
From: Sven Wegener <[email protected]>
Date: Tue, 14 Oct 2008 23:08:17 +0200 (CEST)Quoted 9 lines
Yeah, with the default governor being any of supported governors, we either need some ugly #ifdef mess to only export the governor that is selected or just revert to the old code, which unconditionally exports all governors. Or something like the patch below. With the additional modules that I oversaw and that require the export, I'm fine with just reverting the commit, although I think that encapsulating the default governor decision in a built-in function is cleaner than having modules reference different symbols depending on configuration.
Quoted 1 line
Personally I prefer the revert.
Fine with me. Dave J. or Linus, please revert c4d14bc0bb5d13e316890651ae4518b764c3344c, because it breaks allmodconfig as reported by David Miller on architectures that have cpufreq code that can be build as a module. All ways to only export the default governor are a ifdef mess and ugly, let's just revert the commit.
Thanks,
Sven
Quoted 15 lines · Sven Wegener
Quoted 13 lines · David Miller
From: Sven Wegener <[email protected]>
Date: Tue, 14 Oct 2008 23:08:17 +0200 (CEST)Quoted 9 lines
Yeah, with the default governor being any of supported governors, we either need some ugly #ifdef mess to only export the governor that is selected or just revert to the old code, which unconditionally exports all governors. Or something like the patch below. With the additional modules that I oversaw and that require the export, I'm fine with just reverting the commit, although I think that encapsulating the default governor decision in a built-in function is cleaner than having modules reference different symbols depending on configuration.
Quoted 7 lines
Quoted 1 line
Personally I prefer the revert.
Fine with me. Dave J. or Linus, please revert
c4d14bc0bb5d13e316890651ae4518b764c3344c, because it breaks allmodconfig as reported by David Miller on architectures that have cpufreq code that can be build as a module. All ways to only export the default governor are a ifdef mess and ugly, let's just revert the commit.
Ever wondered why this build failure only happened on sparc, and not on x86? Because the line
policy->governor = CPUFREQ_DEFAULT_GOVERNOR
actually isn't needed in any cpufreq driver (no x86 driver sets it) as it is already set this way in the cpufreq core. Therefore, we can remove this line from all drivers, and keep the cleanup commit c4d14bc0bb5d13e316890651ae4518b764c3344c .
Best,
Dominik
[PATCH] cpufreq: remove policy->governor setting in drivers initialization
As policy->governor is already set to CPUFREQ_DEFAULT_GOVERNOR in the (always built-in) cpufreq core, we do not need to set it in the drivers. This fixes the sparc64 allmodconfig build failure.
Also, remove a totally useles setting of ->policy in cpufreq-pxa3xx.c.
arch/arm/mach-integrator/cpu.c +0 -1
@@ -184,7 +184,6 @@ static int integrator_cpufreq_init(struct cpufreq_policy *policy) {/* set default policy and cpuinfo */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; policy->cpuinfo.max_freq =160000 ; policy->cpuinfo.min_freq =12000 ; policy->cpuinfo.transition_latency =1000000 ;/* 1 ms, assumed */
arch/arm/mach-pxa/cpufreq-pxa2xx.c +0 -3
@@ -335,9 +335,6 @@ static __init int pxa_cpufreq_init(struct cpufreq_policy *policy)pxa27x_guess_max_freq ();/* set default policy and cpuinfo */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; -if (cpu_is_pxa25x ()) - policy->policy =CPUFREQ_POLICY_PERFORMANCE ; policy->cpuinfo.transition_latency =1000 ;/* FIXME: 1 ms, assumed */ policy->cur =get_clk_frequency_khz (0 );/* current freq */ policy->min = policy->max = policy->cur;
arch/arm/mach-pxa/cpufreq-pxa3xx.c +0 -1
@@ -210,7 +210,6 @@ static __init int pxa3xx_cpufreq_init(struct cpufreq_policy *policy)int ret = -EINVAL ;/* set default policy and cpuinfo */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; policy->cpuinfo.min_freq =104000 ; policy->cpuinfo.max_freq = (cpu_is_pxa320 ()) ?806000 :624000 ; policy->cpuinfo.transition_latency =1000 ;/* FIXME: 1 ms, assumed */
arch/arm/mach-sa1100/cpu-sa1100.c +0 -1
@@ -224,7 +224,6 @@ static int __init sa1100_cpu_init(struct cpufreq_policy *policy)if (policy->cpu !=0 )return -EINVAL ; policy->cur = policy->min = policy->max =sa11x0_getspeed (0 ); - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; policy->cpuinfo.min_freq =59000 ; policy->cpuinfo.max_freq =287000 ; policy->cpuinfo.transition_latency =CPUFREQ_ETERNAL ;
arch/avr32/mach-at32ap/cpufreq.c +0 -1
@@ -87,7 +87,6 @@ static int __init at32_cpufreq_driver_init(struct cpufreq_policy *policy) policy->cur =at32_get_speed (0 ); policy->min = policy->cpuinfo.min_freq; policy->max = policy->cpuinfo.max_freq; - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ;printk ("cpufreq: AT32AP CPU frequency driver\n" );
arch/blackfin/mach-common/cpufreq.c +0 -2
@@ -158,8 +158,6 @@ static int __init __bfin_cpu_init(struct cpufreq_policy *policy) dpm_state_table[index].tscale); } - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; - policy->cpuinfo.transition_latency = (bfin_read_PLL_LOCKCNT () / (sclk /1000000 )) *1000 ;/*Now ,only support one cpu */ policy->cur = cclk;
arch/cris/arch-v32/mach-a3/cpufreq.c +0 -1
@@ -85,7 +85,6 @@ static int cris_freq_cpu_init(struct cpufreq_policy *policy)int result;/* cpuinfo and default policy values */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; policy->cpuinfo.transition_latency =1000000 ;/* 1ms */ policy->cur =cris_freq_get_cpu_frequency (0 );
arch/cris/arch-v32/mach-fs/cpufreq.c +0 -1
@@ -81,7 +81,6 @@ static int cris_freq_cpu_init(struct cpufreq_policy *policy)int result;/* cpuinfo and default policy values */ - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; policy->cpuinfo.transition_latency =1000000 ;/* 1ms */ policy->cur =cris_freq_get_cpu_frequency (0 );
arch/sparc64/kernel/us3_cpufreq.c +0 -1
@@ -183,7 +183,6 @@ static int __init us3_freq_cpu_init(struct cpufreq_policy *policy) table[3 ].index =0 ; table[3 ].frequency =CPUFREQ_TABLE_END ; - policy->governor =CPUFREQ_DEFAULT_GOVERNOR ; policy->cpuinfo.transition_latency =0 ; policy->cur = clock_tick;
David Miller
Acked-byFrom: Dominik Brodowski <[email protected]>
Date: Thu, 16 Oct 2008 00:11:04 +0200
Quoted 9 lines
[PATCH] cpufreq: remove
policy->governorsetting in drivers initializationAs
policy->governoris already set toCPUFREQ_DEFAULT_GOVERNORin the (always built-in) cpufreq core, we do not need to set it in the drivers. This fixes the sparc64 allmodconfig build failure.Also, remove a totally useles setting of ->policy in
cpufreq-pxa3xx.c.Signed-off-by Dominik Brodowski <[email protected]>
This works for me: