Skip to contentSkip to conversation

de2104x: wrong MAC address fix

PATCH In review Martin Langer 2 participants 2 messages Oct 13, 2008 – Oct 14, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 de2104x: wrong MAC address fix

The de2104x returns sometimes a wrong MAC address. The wrong one is like the original one, but it comes with an one byte shift. I found this bug on an older alpha ev5 cpu. More details are available in Gentoo bugreport #240718.

It seems the hardware is sometimes a little bit too slow for an immediate access. This patch solves the problem by introducing a small udelay.

net/tulip/de2104x.c renamed from net/tulip/de2104x.c_ORIGINAL +1 -0
@@ -1689,6 +1689,7 @@
 	unsigned i;
 
 	dw32 (ROMCmd, 0);	/* Reset the pointer with a dummy write. */
+	udelay(5);
 
 	for (i = 0; i < 6; i++) {
 		int value, boguscnt = 100000;
maintainer
#1 lore raw

From: Martin Langer <[email protected]>
Date: Mon, 13 Oct 2008 20:04:59 +0200

Quoted 10 lines

The de2104x returns sometimes a wrong MAC address. The wrong one is like the original one, but it comes with an one byte shift. I found this bug on an older alpha ev5 cpu. More details are available in Gentoo bugreport #240718.

It seems the hardware is sometimes a little bit too slow for an immediate access. This patch solves the problem by introducing a small udelay.

Looks good, applied, thanks Martin.

net/tulip/de2104x.c

Quoted 3 lines
net/tulip/de2104x.c renamed from net/tulip/de2104x.c_ORIGINAL +0 -0
@@ -1689,6 +1689,7 @@

Please -p1 base your patches in the future.