ide: cleanup ide_do_request()

PATCH New Bartlomiej Zolnierkiewicz 1 participant 1 message Oct 15, 2008 libata

lore

Share & tools

lore

Bartlomiej Zolnierkiewicz

author

2008-10-15 19:50 UTC #0 lore raw

PATCH 1/1 ide: cleanup ide_do_request()

Both choose_drive() and PM handling code make sure that the queue is unplugged so no need to check it again.

Cc Elias Oltmanns <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
goes before "ide: don't execute the next queued command from the hard-IRQ context" but is independent from it

 drivers/ide/ide-io.c |    5 -----
 1 file changed, 5 deletions(-)

drivers/ide/ide-io.c +0 -5

Index: b/drivers/ide/ide-io.c
===================================================================
@@ -1016,11 +1016,6 @@ static void ide_do_request (ide_hwgroup_
 		drive->dev_flags &= ~(IDE_DFLAG_SLEEPING | IDE_DFLAG_PARKED);
 		drive->service_start = jiffies;
 
-		if (blk_queue_plugged(drive->queue)) {
-			printk(KERN_ERR "ide: huh? queue was plugged!\n");
-			break;
-		}
-
 		/*
 		 * we know that the queue isn't empty, but this can happen
 		 * if the q->prep_rq_fn() decides to kill a request