Skip to contentSkip to conversation

ext4 missing newlines

PATCH In review Eric Sesterhenn 2 participants 2 messages Oct 16, 2008 ext4 file system

lore
Share & tools
lore

Eric Sesterhenn

author
#0 lore raw

PATCH 1/1 ext4 missing newlines

hi,

there are some newlines missing in ext4_check_descriptors, which cause the printk level to be printed out when the next printk call is made:

[  778.847265] EXT4-fs: ext4_check_descriptors: Block bitmap for group 0
not in group (block 1509949442)!<3>EXT4-fs: group descriptors corrupted!
[  802.646630] EXT4-fs: ext4_check_descriptors: Inode bitmap for group 0

not in group (block 9043971)!<3>EXT4-fs: group descriptors corrupted!

Signed-off-by Eric Sesterhenn <[email protected]>
fs/ext4/super.c renamed from fs/ext4/super.c.orig +3 -3
@@ -1618,14 +1618,14 @@ static int ext4_check_descriptors(struct
 		if (block_bitmap < first_block || block_bitmap > last_block) {
 			printk(KERN_ERR "EXT4-fs: ext4_check_descriptors: "
 			       "Block bitmap for group %lu not in group "
-			       "(block %llu)!", i, block_bitmap);
+			       "(block %llu)!\n", i, block_bitmap);
 			return 0;
 		}
 		inode_bitmap = ext4_inode_bitmap(sb, gdp);
 		if (inode_bitmap < first_block || inode_bitmap > last_block) {
 			printk(KERN_ERR "EXT4-fs: ext4_check_descriptors: "
 			       "Inode bitmap for group %lu not in group "
-			       "(block %llu)!", i, inode_bitmap);
+			       "(block %llu)!\n", i, inode_bitmap);
 			return 0;
 		}
 		inode_table = ext4_inode_table(sb, gdp);

@@ -1633,7 +1633,7 @@ static int ext4_check_descriptors(struct
 		    inode_table + sbi->s_itb_per_group - 1 > last_block) {
 			printk(KERN_ERR "EXT4-fs: ext4_check_descriptors: "
 			       "Inode table for group %lu not in group "
-			       "(block %llu)!", i, inode_table);
+			       "(block %llu)!\n", i, inode_table);
 			return 0;
 		}
 		spin_lock(sb_bgl_lock(sbi, i));
maintainer
#1 lore raw
Quoted 4 lines · Eric Sesterhenn

there are some newlines missing in ext4_check_descriptors, which cause the printk level to be printed out when the next printk call is made:

Thanks for the patch; I've added it to the ext4 patch queue.

- Ted