Skip to contentSkip to conversation

mm: page_cgroup needs linux/vmalloc.h for vmalloc_node()/vfree().

PATCH In review Paul Mundt 2 participants 2 messages Oct 21, 2008 Memory management

lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 mm: page_cgroup needs linux/vmalloc.h for vmalloc_node()/vfree().

Trivial build fix for:

CC mm/page_cgroup.o
mm/page_cgroup.c: In function 'init_section_page_cgroup':
mm/page_cgroup.c:111: error: implicit declaration of function 'vmalloc_node' mm/page_cgroup.c:111: warning: assignment makes pointer from integer without a cast mm/page_cgroup.c: In function '__free_page_cgroup':
mm/page_cgroup.c:140: error: implicit declaration of function 'vfree' make[1]: *** [mm/page_cgroup.o] Error 1
make: *** [mm/page_cgroup.o] Error 2

---

 mm/page_cgroup.c |    1 +
 1 file changed, 1 insertion(+)
mm/page_cgroup.c +1 -0
index 5d86550..78242b4 100644
@@ -5,6 +5,7 @@
 #include <linux/page_cgroup.h>
 #include <linux/hash.h>
 #include <linux/memory.h>
+#include <linux/vmalloc.h>
 
 static void __meminit
 __init_page_cgroup(struct page_cgroup *pc, unsigned long pfn)
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · On Tue, 21 Oct 2008 12:36:23 +0900 Paul Mundt <[email protected]> wrote:

Trivial build fix for:

CC mm/page_cgroup.o
mm/page_cgroup.c: In function 'init_section_page_cgroup':
mm/page_cgroup.c:111: error: implicit declaration of function 'vmalloc_node' mm/page_cgroup.c:111: warning: assignment makes pointer from integer without a cast mm/page_cgroup.c: In function '__free_page_cgroup':
mm/page_cgroup.c:140: error: implicit declaration of function 'vfree' make[1]: *** [mm/page_cgroup.o] Error 1
make: *** [mm/page_cgroup.o] Error 2

Quoted 2 lines

Oh, thanks

Quoted 18 lines

---

 mm/page_cgroup.c |    1 +
 1 file changed, 1 insertion(+)
mm/page_cgroup.c +1 -0
index 5d86550..78242b4 100644
@@ -5,6 +5,7 @@
 #include <linux/page_cgroup.h>
 #include <linux/hash.h>
 #include <linux/memory.h>
+#include <linux/vmalloc.h>
 
 static void __meminit
 __init_page_cgroup(struct page_cgroup *pc, unsigned long pfn)