Skip to contentSkip to conversation

Fix page_cgroup build breakage

PATCH In review Heiko Carstens 2 participants 2 messages Oct 21, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix page_cgroup build breakage

Subject: [PATCH] Fix page_cgroup build breakage

From: Heiko Carstens <[email protected]>

On s390 I get this:

CC mm/page_cgroup.o
mm/page_cgroup.c: In function 'init_section_page_cgroup':
mm/page_cgroup.c:111: error: implicit declaration of function 'vmalloc_node' mm/page_cgroup.c:111: warning: assignment makes pointer from integer without a cast mm/page_cgroup.c: In function '__free_page_cgroup':
mm/page_cgroup.c:140: error: implicit declaration of function 'vfree' make[1]: *** [mm/page_cgroup.o] Error 1
make: *** [mm] Error 2

caused by 52d4b9ac0b985168009c2a57098324e67bae171f ("memcg: allocate all page_cgroup at boot")

Cc KAMEZAWA Hiroyuki <[email protected]>
---
 mm/page_cgroup.c |    1 +
 1 file changed, 1 insertion(+)
mm/page_cgroup.c +1 -0
Index: linux-2.6/mm/page_cgroup.c
===================================================================
@@ -3,6 +3,7 @@
 #include <linux/bootmem.h>
 #include <linux/bit_spinlock.h>
 #include <linux/page_cgroup.h>
+#include <linux/vmalloc.h>
 #include <linux/hash.h>
 #include <linux/memory.h>
 
#1 lore raw
Quoted 15 lines · On Tue, 21 Oct 2008 08:12:19 +0200 Heiko Carstens <[email protected]>…

Subject: [PATCH] Fix page_cgroup build breakage

From: Heiko Carstens <[email protected]>

On s390 I get this:

CC mm/page_cgroup.o
mm/page_cgroup.c: In function 'init_section_page_cgroup':
mm/page_cgroup.c:111: error: implicit declaration of function 'vmalloc_node' mm/page_cgroup.c:111: warning: assignment makes pointer from integer without a cast mm/page_cgroup.c: In function '__free_page_cgroup':
mm/page_cgroup.c:140: error: implicit declaration of function 'vfree' make[1]: *** [mm/page_cgroup.o] Error 1
make: *** [mm] Error 2

Quoted 3 lines

caused by 52d4b9ac0b985168009c2a57098324e67bae171f ("memcg: allocate all page_cgroup at boot")

Thank you and sorry.

Note: same as mm-page_cgroup-needs-linux-vmalloch-for-vmalloc_node-vfree.patch
in mm-stack.

Regards,
-Kame