Skip to contentSkip to conversation

x86: Use consistent names for region size and conherence id on x86 and ia64.

PATCH Applied Russ Anderson 2 participants 2 messages Oct 21, 2008 – Oct 22, 2008 x86

lore
Share & tools
lore

Russ Anderson

author
#0 lore raw

PATCH 1/1 x86: Use consistent names for region size and conherence id on x86 and ia64.

Use consistent names for region size and conherence id on x86 and ia64.

Signed-off-by Russ Anderson <[email protected]>

---
The SGI xp drivers are used on both ia64 and x86. Using the same names (sn_coherency_id, sn_region_size) simplies the driver code.

 arch/x86/kernel/bios_uv.c        |    8 ++++----
 arch/x86/kernel/genx2apic_uv_x.c |    4 ++--
 include/asm-x86/uv/bios.h        |    6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)
include/asm-x86/uv/bios.h +3 -3
Index: linux/include/asm-x86/uv/bios.h
===================================================================
@@ -85,9 +85,9 @@ extern void uv_bios_init(void);
 
 extern int uv_type;
 extern long sn_partition_id;
-extern long uv_coherency_id;
-extern long uv_region_size;
-#define partition_coherence_id()	(uv_coherency_id)
+extern long sn_coherency_id;
+extern long sn_region_size;
+#define partition_coherence_id()	(sn_coherency_id)
 
 extern struct kobject *sgi_uv_kobj;	/* /sys/firmware/sgi_uv */
arch/x86/kernel/bios_uv.c +4 -4
Index: linux/arch/x86/kernel/bios_uv.c
===================================================================
@@ -69,10 +69,10 @@ s64 uv_bios_call_reentrant(enum uv_bios_
 
 long sn_partition_id;
 EXPORT_SYMBOL_GPL(sn_partition_id);
-long uv_coherency_id;
-EXPORT_SYMBOL_GPL(uv_coherency_id);
-long uv_region_size;
-EXPORT_SYMBOL_GPL(uv_region_size);
+long sn_coherency_id;
+EXPORT_SYMBOL_GPL(sn_coherency_id);
+long sn_region_size;
+EXPORT_SYMBOL_GPL(sn_region_size);
 int uv_type;
arch/x86/kernel/genx2apic_uv_x.c +2 -2
Index: linux/arch/x86/kernel/genx2apic_uv_x.c
===================================================================
@@ -429,7 +429,7 @@ void __init uv_system_init(void)
 
 	uv_bios_init();
 	uv_bios_get_sn_info(0, &uv_type, &sn_partition_id,
-			    &uv_coherency_id, &uv_region_size);
+			    &sn_coherency_id, &sn_region_size);
 	uv_rtc_init();
 
 	for_each_present_cpu(cpu) {

@@ -451,7 +451,7 @@ void __init uv_system_init(void)
 		uv_cpu_hub_info(cpu)->gpa_mask = (1 << (m_val + n_val)) - 1;
 		uv_cpu_hub_info(cpu)->gnode_upper = gnode_upper;
 		uv_cpu_hub_info(cpu)->global_mmr_base = mmr_base;
-		uv_cpu_hub_info(cpu)->coherency_domain_number = uv_coherency_id;
+		uv_cpu_hub_info(cpu)->coherency_domain_number = sn_coherency_id;
 		uv_node_to_blade[nid] = blade;
 		uv_cpu_to_blade[cpu] = blade;
 		max_pnode = max(pnode, max_pnode);
Signature · 2 lines
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          [email protected]
Applied
#1 lore raw
Quoted 10 lines · Russ Anderson

Use consistent names for region size and conherence id on x86 and ia64.

Signed-off-by Russ Anderson <[email protected]>

---
The SGI xp drivers are used on both ia64 and x86. Using the same names (sn_coherency_id, sn_region_size) simplies the driver code.

Quoted 4 lines
 arch/x86/kernel/bios_uv.c        |    8 ++++----
 arch/x86/kernel/genx2apic_uv_x.c |    4 ++--
 include/asm-x86/uv/bios.h        |    6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

applied to tip/x86/uv, thanks Russ!

Ingo