Skip to contentSkip to conversation

sgi-xp: only build for ia64-sn2 when CONFIG_IA64_GENERIC specified v.2

PATCH In review Dean Nelson 2 participants 3 messages Oct 23, 2008 – Oct 28, 2008 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sgi-xp: only build for ia64-sn2 when CONFIG_IA64_GENERIC specified v.2

For the time being build for ia64-sn2 alone when CONFIG_IA64_GENERIC is specified.

---

 drivers/misc/sgi-xp/Makefile   |    4 ++--
 drivers/misc/sgi-xp/xp.h       |    4 ++++
 drivers/misc/sgi-xp/xpc_main.c |    4 ++--
 3 files changed, 8 insertions(+), 4 deletions(-)
drivers/misc/sgi-xp/Makefile +2 -2
Index: linux/drivers/misc/sgi-xp/Makefile
===================================================================
@@ -5,14 +5,14 @@
 obj-$(CONFIG_SGI_XP)		+= xp.o
 xp-y				:= xp_main.o
 xp-$(CONFIG_IA64_SGI_SN2)	+= xp_sn2.o xp_nofault.o
-xp-$(CONFIG_IA64_GENERIC)	+= xp_sn2.o xp_nofault.o xp_uv.o
+xp-$(CONFIG_IA64_GENERIC)	+= xp_sn2.o xp_nofault.o
 xp-$(CONFIG_IA64_SGI_UV)	+= xp_uv.o
 xp-$(CONFIG_X86_64)		+= xp_uv.o
 
 obj-$(CONFIG_SGI_XP)		+= xpc.o
 xpc-y				:= xpc_main.o xpc_channel.o xpc_partition.o
 xpc-$(CONFIG_IA64_SGI_SN2)	+= xpc_sn2.o
-xpc-$(CONFIG_IA64_GENERIC)	+= xpc_sn2.o xpc_uv.o
+xpc-$(CONFIG_IA64_GENERIC)	+= xpc_sn2.o
 xpc-$(CONFIG_IA64_SGI_UV) 	+= xpc_uv.o
 xpc-$(CONFIG_X86_64)		+= xpc_uv.o
 
drivers/misc/sgi-xp/xp.h +4 -0
Index: linux/drivers/misc/sgi-xp/xp.h
===================================================================
@@ -19,7 +19,11 @@
 #include <asm/system.h>
 #include <asm/sn/arch.h>	/* defines is_shub1() and is_shub2() */
 #define is_shub()	ia64_platform_is("sn2")
+#ifdef CONFIG_IA64_SGI_UV
 #define is_uv()		ia64_platform_is("uv")
+#else
+#define is_uv()		0
+#endif
 #endif
 #ifdef CONFIG_X86_64
 #include <asm/genapic.h>
drivers/misc/sgi-xp/xpc_main.c +2 -2
Index: linux/drivers/misc/sgi-xp/xpc_main.c
===================================================================
@@ -1104,7 +1104,7 @@ xpc_do_exit(enum xp_retval reason)
 
 	if (is_shub())
 		xpc_exit_sn2();
-	else
+	else if (is_uv())
 		xpc_exit_uv();
 }
 
@@ -1363,7 +1363,7 @@ out_2:
 out_1:
 	if (is_shub())
 		xpc_exit_sn2();
-	else
+	else if (is_uv())
 		xpc_exit_uv();
 	return ret;
 }
#1 lore raw
Quoted 3 lines · On Thu, 23 Oct 2008 13:33:35 -0500 Dean Nelson <[email protected]> wrote:

For the time being build for ia64-sn2 alone when CONFIG_IA64_GENERIC is specified.

It is 100% unclear (to me) why this change is being made.

Apparently this is considered a needed-in-2.6.28 change. But I don't know why.

If I knew that then I'd be in a better position to work out whether it is also needed in 2.6.27.x, to which it also applies cleanly.

IOW: better changelogs, please.

#2 lore raw
Quoted 8 lines · Andrew Morton
Quoted 3 lines · On Thu, 23 Oct 2008 13:33:35 -0500 Dean Nelson <[email protected]> wrote:

For the time being build for ia64-sn2 alone when CONFIG_IA64_GENERIC is specified.

It is 100% unclear (to me) why this change is being made.

It eliminates a dependency of the XP/XPC drivers on having the GRU driver insmod'd in order to insmod them, when running on an ia64-sn2 system.

On such a system the GRU driver serves no useful purpose.

Quoted 6 lines

Apparently this is considered a needed-in-2.6.28 change. But I don't know why.

If I knew that then I'd be in a better position to work out whether it is also needed in 2.6.27.x, to which it also applies cleanly.

Having it applied to 2.6.27.x would be a good thing.

Quoted 1 line

IOW: better changelogs, please.

Sorry.