Skip to contentSkip to conversation

odd change to drivers/net/ibm_newemac/core.c

DISCUSSION Christoph Hellwig 2 participants 2 messages Oct 23, 2008

lore
Share & tools
lore
#1 lore raw
In reply to Christoph Hellwig
Quoted 10 lines · On Thu, 23 Oct 2008 23:41:48 +0200 Christoph Hellwig <[email protected]> wrote:
(quoted diff) +6 -0
+#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
                        dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
+#else
+                       printk(KERN_ERR "%s: Flow control not disabled!\n",
+					np->full_name);
+                       return -ENXIO;
+#endif

What's this trying to do? CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL doesn't exist anywhere, and it seems like an extremly strange idea for a config

Damnit. Typo. Should be CONFIG_IBM_NEW_EMAC_NO_FLOW_CTRL. It's right elsewhere, I just fat-fingered the option with this particular change because I was rushing for a build fix. I'll fix it with the brown paper bag of shame over my head shortly.

Quoted 2 lines

option. And "Flow control not disabled" is not an extremly useful error message for users either..

Normal users aren't supposed to set it. The option is selected by the 4xx platform config options on boards that need the feature. This is how other things are done in the EMAC driver.

josh

#0 lore raw

+#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL

                        dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;

+#else
+ printk(KERN_ERR "%s: Flow control not disabled!\n",
+ np->full_name);
+ return -ENXIO;
+#endif

What's this trying to do? CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL doesn't exist anywhere, and it seems like an extremly strange idea for a config option. And "Flow control not disabled" is not an extremly useful error message for users either..