Skip to contentSkip to conversation

kgdb:remove redundant function invocation

PATCH RESEND New Qinghuang Feng 1 participant 1 message Oct 25, 2008

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 kgdb:remove redundant function invocation

Sorry for my resending, the previous patch can't be applied successfully.

It seems strange to call kgdboc_option_setup with parameter of config from configure_kgdboc(), because kgdboc_option_setup() is used to fill config with stuff in other place. Now, kgdboc_option_setup will fill config with config itself. But on the other hand, kgdboc_option_setup has a additional effect to check whether config overflows or not.

Is it ok to remove kgdboc_option_setup?

---

drivers/serial/kgdboc.c +1 -2
index eadc1ab..03f683e 100644
@@ -51,8 +51,7 @@ static int configure_kgdboc(void)
 	int tty_line = 0;
 	int err;
 
-	err = kgdboc_option_setup(config);
-	if (err || !strlen(config) || isspace(config[0]))
+	if (!strlen(config) || isspace(config[0]))
 		goto noconfig;
 
 	err = -ENODEV;