Skip to contentSkip to conversation

disable the right device

PATCH Applied Phil Sutter 2 participants 4 messages Oct 27, 2008 1 message not in the archive

Subsystems (2)
MIPS libata
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Phil Sutter

author
#1 lore raw

PATCH 1/1 disable the right device

Signed-off-by Florian Fainelli <[email protected]>
---
 arch/mips/rb532/devices.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/mips/rb532/devices.c +1 -1
index 31619c6..2f22d71 100644
@@ -280,7 +280,7 @@ static int __init plat_setup_devices(void)
 {
 	/* Look for the CF card reader */
 	if (!readl(IDT434_REG_BASE + DEV1MASK))
-		rb532_devs[1] = NULL;
+		rb532_devs[2] = NULL;	/* disable cf_slot0 at index 2 */
 	else {
 		cf_slot0_res[0].start =
 		    readl(IDT434_REG_BASE + DEV1BASE);
Signature · 1 line
1.5.6.4
Applied
#2 lore raw

On Mon, Oct 27, 2008 at 02:29:57AM +0100, Phil Sutter wrote:

Thanks, applied.

Ralf

author
#3 lore raw

PATCH 1/1 irq handler must disable the handled irq

In reply to a message not in the archive
Signed-off-by Florian Fainelli <[email protected]>
---
 drivers/ata/pata_rb532_cf.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/ata/pata_rb532_cf.c +2 -0
index f8b3ffc..a1d44a6 100644
@@ -116,6 +116,8 @@ static irqreturn_t rb532_pata_irq_handler(int irq, void *dev_instance)
 		set_irq_type(info->irq, IRQ_TYPE_LEVEL_HIGH);
 	}
 
+	disable_irq(irq);
+
 	return IRQ_HANDLED;
 }
Signature · 1 line
1.5.6.4
#4 lore raw

Re: [PATCH] irq handler must disable the handled irq

Quoted 2 lines · Phil Sutter
 drivers/ata/pata_rb532_cf.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Please send this patch to the IDE maintainer & list.

Ralf