CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64
Subsystems (2)
Hi Mike, Eric, Richard,
With CONFIG_LEDS_DA903X=m, kernel 2.6.28-rc2-git1 fails to build on x86-64 with the following error:
CC [M] drivers/leds/leds-da903x.odrivers/leds/leds-da903x.c:35: error: field "work" has incomplete type drivers/leds/leds-da903x.c: In function "da903x_led_work":drivers/leds/leds-da903x.c:47: warning: type defaults to "int" in declaration of "__mptr" drivers/leds/leds-da903x.c:47: warning: initialization from incompatible pointer type drivers/leds/leds-da903x.c: In function "da903x_led_set":drivers/leds/leds-da903x.c:89: error: implicit declaration of function "schedule_work" drivers/leds/leds-da903x.c: In function "da903x_led_probe":drivers/leds/leds-da903x.c:125: error: implicit declaration of function "INIT_WORK"
Can we PLEASE stick to the plan and ONLY have bug FIXES after rc1 (and even more so after rc2)?
Thanks,
Signature · 1 line
Jean Delvare
This is strange, it compiles OK on ARM, I don't know why this failed on x86-64. But anyway, <linux/workqueue.h> should really be explicitly included here.
The attached patch should fix this.
- eric
-----Original Message-----
From: Jean Delvare [mailto:[email protected]]
Sent: Monday, October 27, 2008 4:45 PM
To: Mike Rapoport; Eric Miao; Richard Purdie
Cc: LKML; Linus Torvalds
Subject: CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64
Hi Mike, Eric, Richard,
With CONFIG_LEDS_DA903X=m, kernel 2.6.28-rc2-git1 fails to build on x86-64 with the following error:
CC [M] drivers/leds/leds-da903x.odrivers/leds/leds-da903x.c:35: error: field "work" has incomplete type drivers/leds/leds-da903x.c: In function "da903x_led_work":drivers/leds/leds-da903x.c:47: warning: type defaults to "int" in declaration of "__mptr"drivers/leds/leds-da903x.c:47: warning: initialization from incompatible pointer typedrivers/leds/leds-da903x.c: In function "da903x_led_set":drivers/leds/leds-da903x.c:89: error: implicit declaration of function "schedule_work"drivers/leds/leds-da903x.c: In function "da903x_led_probe":drivers/leds/leds-da903x.c:125: error: implicit declaration of function "INIT_WORK"
Can we PLEASE stick to the plan and ONLY have bug FIXES after rc1 (and even more so after rc2)?
Thanks,
Signature · 1 line
Jean Delvare
From 2d82121aaecf73b66285cc1c0bf241c87afe7293 Mon Sep 17 00:00:00 2001
From: Eric Miao <[email protected]>
Date: Mon, 27 Oct 2008 17:48:50 +0800
Subject: [PATCH] leds: da903x: fix the building failure of incomplete type of 'work'
With CONFIG_LEDS_DA903X=m, kernel 2.6.28-rc2-git1 fails to build on x86-64 with the following error:
CC [M] drivers/leds/leds-da903x.odrivers/leds/leds-da903x.c:35: error: field "work" has incomplete type drivers/leds/leds-da903x.c: In function "da903x_led_work":drivers/leds/leds-da903x.c:47: warning: type defaults to "int" in declaration of "__mptr" drivers/leds/leds-da903x.c:47: warning: initialization from incompatible pointer type drivers/leds/leds-da903x.c: In function "da903x_led_set":drivers/leds/leds-da903x.c:89: error: implicit declaration of function "schedule_work" drivers/leds/leds-da903x.c: In function "da903x_led_probe":drivers/leds/leds-da903x.c:125: error: implicit declaration of function "INIT_WORK"
Include the <linux/workqueue.h> explicitly here to fix the above issue.
--- drivers/leds/leds-da903x.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/leds/leds-da903x.c +1 -0
@@ -17,6 +17,7 @@#include <linux/init.h> #include <linux/platform_device.h> #include <linux/leds.h> +#include <linux/workqueue.h> #include <linux/mfd/da903x.h> #define DA9030_LED1_CONTROL 0x20
Signature · 1 line
1.6.0.2
Jean Delvare
Acked-byHi Eric,
Quoted 5 lines · Eric Miao
This is strange, it compiles OK on ARM, I don't know why this failed on x86-64. But anyway, <
linux/workqueue.h> should really be explicitly included here.The attached patch should fix this.
Yes it does, thanks for the quick fix. Please get this upstream quickly too.
Signature · 1 line
Jean Delvare