include/linux/mca-legacy.h: Fix the warning of note
--- include/linux/mca-legacy.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/mca-legacy.h +1 -1
@@ -9,7 +9,7 @@#include <linux/mca.h> -#warning "MCA legacy - please move your driver to the new sysfs api" +/* warning "MCA legacy - please move your driver to the new sysfs api" */ /* MCA_NOTFOUND is an error condition. The other two indicate * motherboard POS registers contain the adapter. They might be
Signature · 7 lines
1.5.2.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Andrew Morton
maintainerQuoted 1 line · On Wed, 29 Oct 2008 09:49:18 +0800 Jianjun Kong <[email protected]> wrote:
include/linux/mca-legacy.h: Fix the warning of note
When preparing patch changelogs, it is usually not sufficient to just describe the change itself. Often that is obvious from the patch itself, as in this case.
Instead, please take care to explain to us *why* a change was made.
Quoted 10 lines
Signed-off-by Jianjun Kong <[email protected]>--- include/linux/mca-legacy.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)include/linux/mca-legacy.h +0
-0
include/linux/mca-legacy.h line 15
Quoted 8 lines
include/linux/mca-legacy.h +1
-1@@ -9,7 +9,7 @@#include <linux/mca.h> -#warning "MCA legacy - please move your driver to the new sysfs api" +/* warning "MCA legacy - please move your driver to the new sysfs api" */ /* MCA_NOTFOUND is an error condition. The other two indicate * motherboard POS registers contain the adapter. They might be
Why was this change made?
As far as I can tell, the patch is wrong? Any driver which is using the interfaces declared by mca-legacy.h should be changed to use the sysfs API (whatever that is - I'm not sure).
So this warning should remain in place until all such drivers have been converted to that API.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>