Skip to contentSkip to conversation

scripts/package: don't break if %{_smp_mflags} isn't set

PATCH In review [email protected] 1 participant 1 message Oct 29, 2008 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 4/13 scripts/package: don't break if %{_smp_mflags} isn't set

From: Jeremy Kerr <[email protected]>

Currently, if we do a 'make rpm-pkg' without the _smp_mflags rpm macro defined, the build fails with:

[snip]
Executing(%build): /bin/bash -e /var/tmp/rpm-tmp.67959
+ umask 022
+ cd /home/jk/devel/kernel-snapshot/rpm/BUILD
+ cd kernel-2.6.26
+ make clean
+ make '%{_smp_mflags}'
make[3]: *** No rule to make target `%{_smp_mflags}'. Stop.
error: Bad exit status from /var/tmp/rpm-tmp.67959 (%build)

This change uses the 'null if not set' reference to the _smp_mflags macro instead.

---

 scripts/package/mkspec |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/package/mkspec renamed from scripts/package/mkspec~scripts-package-dont-break-if-%_smp_mflags-isnt-set +1 -1
diff -puN scripts/package/mkspec~scripts-package-dont-break-if-%_smp_mflags-isnt-set scripts/package/mkspec
@@ -57,7 +57,7 @@ fi
 echo "%build"
 
 if ! $PREBUILT; then
-echo "make clean && make %{_smp_mflags}"
+echo "make clean && make %{?_smp_mflags}"
 echo ""
 fi
 

_