Skip to contentSkip to conversation

net: kconfig cleanup

PATCH In review Jeff Kirsher 2 participants 2 messages Oct 31, 2008 – Nov 2, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Jeff Kirsher

author
#0 lore raw

PATCH 1/1 net: kconfig cleanup

The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, so this patch adds a description to the kconfig option.

Signed-off-by Jeff Kirsher <[email protected]>
CC Andrew Gallatin <[email protected]>

---

 drivers/net/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/Kconfig +2 -2
index f749b40..b13a7ff 100644
@@ -2437,7 +2437,7 @@ config IXGBE
 	  will be called ixgbe.
 
 config IXGBE_DCA
-	bool
+	bool "Enable DCA"
 	default y
 	depends on IXGBE && DCA && !(IXGBE=y && DCA=m)
 

@@ -2489,7 +2489,7 @@ config MYRI10GE
 	  will be called myri10ge.
 
 config MYRI10GE_DCA
-	bool
+	bool "Enable DCA"
 	default y
 	depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)
#1 lore raw
Quoted 24 lines · Jeff Kirsher

The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, so this patch adds a description to the kconfig option.

Signed-off-by Jeff Kirsher <[email protected]>
CC Andrew Gallatin <[email protected]>

---

 drivers/net/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/Kconfig +1 -1
index f749b40..b13a7ff 100644
@@ -2437,7 +2437,7 @@ config IXGBE
 	  will be called ixgbe.
 
 config IXGBE_DCA
-	bool
+	bool "Enable DCA"
 	default y
 	depends on IXGBE && DCA && !(IXGBE=y && DCA=m)

drivers/net/Kconfig config MYRI10GE · line 2494

Quoted 7 lines
drivers/net/Kconfig +1 -1
@@ -2489,7 +2489,7 @@ config MYRI10GE
 	  will be called myri10ge.
 
 config MYRI10GE_DCA
-	bool
+	bool "Enable DCA"
 	default y
 	depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)

If you're gonna do that, please add useful help text for the user who has no idea what this means. (IGB_DCA needs this as well)

Jeff