Skip to contentSkip to conversation

External toolchain C++ cross-compiler fix

PATCH New Thomas Petazzoni 3 participants 5 messages Oct 31, 2008 – Nov 3, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 External toolchain C++ cross-compiler fix

External toolchain C++ cross-compiler fix

package/Makefile.in resets CXX to "" in TARGET_CONFIGURE_OPTS if BR2_GCC_CROSS_CXX is not set to 'y'. However, when using an external toolchain, BR2_GCC_CROSS_CXX is not set even if the toolchain has a C++ cross-compiler.

This patch adds a new BR2_GCC_CROSS_CXX option in the external toolchain configuration menu, so that just like BR2_INET_RPC, BR2_INET_IPV6 and the others, it can be set according to the external toolchain configuration.

---
 toolchain/external-toolchain/Config.in |    6 ++++++
 1 file changed, 6 insertions(+)
toolchain/external-toolchain/Config.in +6 -0
Index: buildroot2/toolchain/external-toolchain/Config.in
===================================================================
@@ -93,6 +93,12 @@
 	help
 	  Set this option if the external toolchain supports soft float.
 
+config BR2_GCC_CROSS_CXX
+	bool "Toolchain has C++ cross-compiler ?"
+	help
+	  Set this option if the external toolchain has a C++
+	  cross-compiler.
+
 config BR2_TARGET_OPTIMIZATION
 	string "Target Optimizations"
 	default "-Os -pipe"
Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
#1 lore raw

PATCH 1/1 External toolchain C++ cross-compiler fix

Quoted 7 lines · Thomas Petazzoni

External toolchain C++ cross-compiler fix

package/Makefile.in resets CXX to "" in TARGET_CONFIGURE_OPTS if BR2_GCC_CROSS_CXX is not set to 'y'. However, when using an external toolchain, BR2_GCC_CROSS_CXX is not set even if the toolchain has a C++ cross-compiler.

Quoted 6 lines

This patch adds a new BR2_GCC_CROSS_CXX option in the external toolchain configuration menu, so that just like BR2_INET_RPC, BR2_INET_IPV6 and the others, it can be set according to the external toolchain configuration.

Yah! Someone else had the same problem.

I posted a message about this back on 8/13/2008 with a similar fix (but not a patch) and never got a reply. I was starting to think it was just me.

For what it's worth:

#2 lore raw

PATCH 1/1 External toolchain C++ cross-compiler fix

Le Fri, 31 Oct 2008 14:32:08 -0400, "hartleys" <[email protected]> a ?crit :

Quoted 3 lines

I posted a message about this back on 8/13/2008 with a similar fix (but not a patch) and never got a reply. I was starting to think it was just me.

No, that's not just you. Not everybody is using Buildroot with the external toolchain set-up (considering the number of issues faced by people using it in this setup), and many patches remained unanswered unfortunately.

Quoted 1 line

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/1 External toolchain C++ cross-compiler fix

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> Le Fri, 31 Oct 2008 14:32:08 -0400, Thomas> "hartleys" <[email protected]> a ?crit :

Quoted 3 lines
Quoted 3 lines

I posted a message about this back on 8/13/2008 with a similar fix (but not a patch) and never got a reply. I was starting to think it was just me.

Thomas> No, that's not just you. Not everybody is using Buildroot with the Thomas> external toolchain set-up (considering the number of issues faced by Thomas> people using it in this setup), and many patches remained unanswered Thomas> unfortunately.

Yeah - It's an issue of limited man power, nothing else.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 External toolchain C++ cross-compiler fix

In reply to Thomas Petazzoni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> External toolchain C++ cross-compiler fix

Thanks, committed as r23910.

Signature · 1 line
Bye, Peter Korsgaard