Skip to contentSkip to conversation

H4: fix i2c registration

PATCH In review David Brownell 2 participants 2 messages Nov 1, 2008 – Nov 13, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 H4: fix i2c registration

From: David Brownell <[email protected]>

Registering the I2C devices on H4 boards once is enough; remove the extra call.

---
Mainline doesn't have the call to register the I2C adapter along with its devices ... this has that call *plus* the call to register just the board_info. Seems to be the only OMAP2/3 board with this bug.

 arch/arm/mach-omap2/board-h4.c |    3 ---
 1 file changed, 3 deletions(-)
arch/arm/mach-omap2/board-h4.c +0 -3
@@ -746,9 +746,6 @@ static void __init omap_h4_init(void)
 	/* Menelaus interrupt */
 	omap_cfg_reg(W19_24XX_SYS_NIRQ);
 
-	i2c_register_board_info(1, h4_i2c_board_info,
-			ARRAY_SIZE(h4_i2c_board_info));
-
 	platform_add_devices(h4_devices, ARRAY_SIZE(h4_devices));
 	omap_board_config = h4_config;
 	omap_board_config_size = ARRAY_SIZE(h4_config);
maintainer
#1 lore raw
Quoted 11 lines · David Brownell

From: David Brownell <[email protected]>

Registering the I2C devices on H4 boards once is enough; remove the extra call.

---
Mainline doesn't have the call to register the I2C adapter along with its devices ... this has that call *plus* the call to register just the board_info. Seems to be the only OMAP2/3 board with this bug.

Pushing to l-o, not adding to upstream queue.

Tony

Quoted 20 lines
 arch/arm/mach-omap2/board-h4.c |    3 ---
 1 file changed, 3 deletions(-)
arch/arm/mach-omap2/board-h4.c +0 -4
@@ -746,9 +746,6 @@ static void __init omap_h4_init(void)
 	/* Menelaus interrupt */
 	omap_cfg_reg(W19_24XX_SYS_NIRQ);
 
-	i2c_register_board_info(1, h4_i2c_board_info,
-			ARRAY_SIZE(h4_i2c_board_info));
-
 	platform_add_devices(h4_devices, ARRAY_SIZE(h4_devices));
 	omap_board_config = h4_config;
 	omap_board_config_size = ARRAY_SIZE(h4_config);
--

To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html