Skip to contentSkip to conversation

remove incorrect comment in inode_permission

PATCH In review Christoph Hellwig 2 participants 2 messages Nov 5, 2008 – Nov 6, 2008 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove incorrect comment in inode_permission

We now pass on all MAY_ flags to the filesystems permission routines, so remove the comment stating the contrary.

fs/namei.c +0 -1
Index: linux-2.6/fs/namei.c
===================================================================
@@ -257,7 +257,6 @@ int inode_permission(struct inode *inode
 			return -EACCES;
 	}
 
-	/* Ordinary permission routines do not understand MAY_APPEND. */
 	if (inode->i_op && inode->i_op->permission)
 		retval = inode->i_op->permission(inode, mask);
 	else
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Christoph Hellwig

We now pass on all MAY_ flags to the filesystems permission routines, so remove the comment stating the contrary.

Looks good.
Looks like an oversight from when the submask and MAY_APPEND clearing lines of code were taken out.

Quoted 19 lines

Index: linux-2.6/fs/namei.c
===================================================================

fs/namei.c +0 -2
@@ -257,7 +257,6 @@ int inode_permission(struct inode *inode
 			return -EACCES;
 	}
 
-	/* Ordinary permission routines do not understand MAY_APPEND. */
 	if (inode->i_op && inode->i_op->permission)
 		retval = inode->i_op->permission(inode, mask);
 	else
--

To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html