account_steal_time: kill the unneeded account_group_system_time()
PATCH 2/3 account_steal_time: kill the unneeded account_group_system_time()
I don't actually understand account_steal_time() and I failed to find the commit which added account_group_system_time(), but this looks bogus. In any case rq->idle must be single-threaded, so it can't have ->totals.
Signed-off-by Oleg Nesterov <[email protected]>
kernel/sched.c renamed from kernel/sched.c~ACCT_STEAL_KILL_GACCT +0 -1
@@ -4198,7 +4198,6 @@ void account_steal_time(struct task_struif (p == rq->idle) { p->stime =cputime_add (p->stime, steal); -account_group_system_time (p, steal);if (atomic_read (&rq->nr_iowait) >0 ) cpustat->iowait =cputime64_add (cpustat->iowait, tmp);else
Quoted 9 lines · Oleg Nesterov
I don't actually understand
account_steal_time()and I failed to find the commit which addedaccount_group_system_time(), but this looks bogus. In any caserq->idlemust be single-threaded, so it can't have ->totals.Signed-off-by Oleg Nesterov <[email protected]>
kernel/sched.c void account_steal_time(struct task_stru · line 4202
Quoted 6 lines
kernel/sched.c renamed from kernel/sched.c~ACCT_STEAL_KILL_GACCT +0
-1@@ -4198,7 +4198,6 @@ void account_steal_time(struct task_struif (p == rq->idle) { p->stime =cputime_add (p->stime, steal); -account_group_system_time (p, steal);if (atomic_read (&rq->nr_iowait) >0 ) cpustat->iowait =cputime64_add (cpustat->iowait, tmp);
could be a typo - is there no similar construct nearby?
Makes sense in any case, applied to tip/core/signal - thanks Oleg.
Ingo