Skip to contentSkip to conversation

x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

PATCH Pallipadi, Venkatesh 3 participants 7 messages Dec 15, 2008 – Dec 18, 2008 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Ingo,

Haven't seen any comments on the patches here. Can you push these patches along to tip.

Thanks,
Venki

Quoted 40 lines

-----Original Message-----
From: Pallipadi, Venkatesh
Sent: Tuesday, November 25, 2008 4:22 PM
To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; linux-kernel@; Siddha, Suresh B
Subject: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

Followup for the patches posted earlier here:
http://marc.info/?l=linux-kernel&m=122653213110404&w=2

Drivers use mmap followed by pgprot_* and remap_pfn_range or vm_insert_pfn,
in order to export reserved memory to userspace. Currently, such mappings are
not tracked and hence not kept consistent with other mappings (/dev/mem,
pci resource, ioremap) for the sme memory, that may exist in the system.

The following patchset adds x86 PAT attribute tracking and untracking for
pfnmap related APIs.

First three patches in the patchset are changing the generic mm code to fit
in this tracking. Last four patches are x86 specific to make things work
with x86 PAT code. The patchset aso introduces pgprot_writecombine interface,
which gives writecombine mapping when enabled, falling back to pgprot_noncached otherwise.

--

#2 lore raw
Quoted 4 lines · Pallipadi, Venkatesh

Ingo,

Haven't seen any comments on the patches here. Can you push these patches along to tip.

while the main focus of the changes are x86, they touch the MM non-trivially too:

   include/linux/mm.h |    9 +++++++++
   mm/memory.c        |    7 +++----
   2 files changed, 12 insertions(+), 4 deletions(-)
   mm/memory.c |    2 ++
   1 file changed, 2 insertions(+)
   include/linux/mm.h |    3 +++
   mm/memory.c        |   43 +++++++++++++++++++++++++++++++++++++++++++
   2 files changed, 46 insertions(+)
   include/linux/mm.h |    6 +++++
   mm/memory.c        |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
   2 files changed, 59 insertions(+), 1 deletion(-)

So when you sent this a month ago i asked the MM folks whether they have any problems with these patches. Acks (or objections) from Andrew, Nick or Hugh would be nice to have.

Ingo

#3 lore raw
Quoted 22 lines · Ingo Molnar
Quoted 4 lines · Pallipadi, Venkatesh

Ingo,

Haven't seen any comments on the patches here. Can you push these patches along to tip.

while the main focus of the changes are x86, they touch the MM non-trivially too:

   include/linux/mm.h |    9 +++++++++
   mm/memory.c        |    7 +++----
   2 files changed, 12 insertions(+), 4 deletions(-)
   mm/memory.c |    2 ++
   1 file changed, 2 insertions(+)
   include/linux/mm.h |    3 +++
   mm/memory.c        |   43 +++++++++++++++++++++++++++++++++++++++++++
   2 files changed, 46 insertions(+)
Quoted 7 lines
   include/linux/mm.h |    6 +++++
   mm/memory.c        |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
   2 files changed, 59 insertions(+), 1 deletion(-)

So when you sent this a month ago i asked the MM folks whether they have any problems with these patches. Acks (or objections) from Andrew, Nick or Hugh would be nice to have.

Last I looked at them, I think all my questions were cleared up.

Acked-by Nick Piggin
#4 lore raw
Quoted 27 lines · Nick Piggin
Quoted 26 lines · Ingo Molnar
Quoted 4 lines · Pallipadi, Venkatesh

Ingo,

Haven't seen any comments on the patches here. Can you push these patches along to tip.

while the main focus of the changes are x86, they touch the MM non-trivially too:

   include/linux/mm.h |    9 +++++++++
   mm/memory.c        |    7 +++----
   2 files changed, 12 insertions(+), 4 deletions(-)
   mm/memory.c |    2 ++
   1 file changed, 2 insertions(+)
   include/linux/mm.h |    3 +++
   mm/memory.c        |   43 +++++++++++++++++++++++++++++++++++++++++++
   2 files changed, 46 insertions(+)
   include/linux/mm.h |    6 +++++
   mm/memory.c        |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
   2 files changed, 59 insertions(+), 1 deletion(-)
Quoted 5 lines
Quoted 3 lines

So when you sent this a month ago i asked the MM folks whether they have any problems with these patches. Acks (or objections) from Andrew, Nick or Hugh would be nice to have.

Last I looked at them, I think all my questions were cleared up.

does that transform into a:

? :-)

Ingo

#5 lore raw
Quoted 11 lines · Ingo Molnar
Quoted 5 lines · Nick Piggin
Quoted 3 lines

So when you sent this a month ago i asked the MM folks whether they have any problems with these patches. Acks (or objections) from Andrew, Nick or Hugh would be nice to have.

Last I looked at them, I think all my questions were cleared up.

does that transform into a:

I should think so ;), but I'll take another glance at the next round after Andrew's comments were incorporated. Are those available?

#6 lore raw
Quoted 7 lines · Nick Piggin
Quoted 6 lines · Ingo Molnar
Quoted 4 lines · Nick Piggin
Quoted 3 lines

So when you sent this a month ago i asked the MM folks whether they have any problems with these patches. Acks (or objections) from Andrew, Nick or Hugh would be nice to have.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Last I looked at them, I think all my questions were cleared up.

does that transform into a:

I should think so ;), but I'll take another glance at the next round after Andrew's comments were incorporated. Are those available?

not yet available - Venki, would you mind to resend the series with those bits fixed, so that Nick can have a look at the end result? Thanks,

Ingo

#7 lore raw
Quoted 27 lines

-----Original Message-----
From: Ingo Molnar [mailto:[email protected]]
Sent: Thursday, December 18, 2008 6:32 AM
To: Nick Piggin
Cc: Pallipadi, Venkatesh; Andrew Morton; Hugh Dickins; [email protected]; [email protected]; [email protected]
Subject: Re: [patch 0/7] x86 PAT: v2 - track pfnmap mappings with remap_pfn_range and vm_insert_pfn

Quoted 4 lines · Nick Piggin
Quoted 3 lines · Ingo Molnar
Quoted 1 line · Nick Piggin
Quoted 1 line

So when you sent this a month ago i asked the MM folks

whether they have

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

any problems with these patches. Acks (or objections)

from Andrew, Nick or

Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Hugh would be nice to have.

Last I looked at them, I think all my questions were cleared up.

does that transform into a:

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

I should think so ;), but I'll take another glance at the next round after Andrew's comments were incorporated. Are those available?

not yet available - Venki, would you mind to resend the series with those
bits fixed, so that Nick can have a look at the end result? Thanks,

Yes. Working on it right now and should have it later today..

Thanks,
Venki