Skip to contentSkip to conversation

Defconfigs and RTC

DISCUSSION Ralf Baechle 2 participants 4 messages Dec 1, 2008 – Dec 2, 2008 MIPS

lore
Share & tools
lore
#0 lore raw

Quite a few of the defconfigs have not been updated for quite some time and are beginning to be a bit useless. Also since we switched to RTC_LIB quite a few systems no longer read their RTCs on bootup so their defconfigs should be updated to enable RTC_CLASS and CONFIG_RTC_HCTOSYS. A hand full of systems is still using read_persistent_clock() to read the RTC on bootup. The use of this function should preferably be replaced by RTC_CLASS and CONFIG_RTC_HCTOSYS.

Ralf

#1 lore raw
Quoted 8 lines · Ralf Baechle

Quite a few of the defconfigs have not been updated for quite some time and are beginning to be a bit useless. Also since we switched to RTC_LIB quite a few systems no longer read their RTCs on bootup so their defconfigs should be updated to enable RTC_CLASS and CONFIG_RTC_HCTOSYS. A hand full of systems is still using read_persistent_clock() to read the RTC on bootup. The use of this function should preferably be replaced by RTC_CLASS and CONFIG_RTC_HCTOSYS.

Can we use RTC_CLASS option directly to replace RTC_LIB on the file, arch/mips/Kconfig by default? If so all deconfigs may not be modified.

Best Regards
Tiejun

Quoted 3 lines

Ralf

#2 lore raw
Quoted 10 lines · tiejun.chen
Quoted 8 lines · Ralf Baechle

Quite a few of the defconfigs have not been updated for quite some time and are beginning to be a bit useless. Also since we switched to RTC_LIB quite a few systems no longer read their RTCs on bootup so their defconfigs should be updated to enable RTC_CLASS and CONFIG_RTC_HCTOSYS. A hand full of systems is still using read_persistent_clock() to read the RTC on bootup. The use of this function should preferably be replaced by RTC_CLASS and CONFIG_RTC_HCTOSYS.

Quoted 2 lines

Can we use RTC_CLASS option directly to replace RTC_LIB on the file, arch/mips/Kconfig by default? If so all deconfigs may not be modified.

RTC_CLASS implies RTC_LIB. It's not a replacement.

Ralf

#3 lore raw
Quoted 11 lines · Ralf Baechle
Quoted 9 lines · tiejun.chen
Quoted 8 lines · Ralf Baechle

Quite a few of the defconfigs have not been updated for quite some time and are beginning to be a bit useless. Also since we switched to RTC_LIB quite a few systems no longer read their RTCs on bootup so their defconfigs should be updated to enable RTC_CLASS and CONFIG_RTC_HCTOSYS. A hand full of systems is still using read_persistent_clock() to read the RTC on bootup. The use of this function should preferably be replaced by RTC_CLASS and CONFIG_RTC_HCTOSYS.

Quoted 5 lines
Quoted 2 lines

Can we use RTC_CLASS option directly to replace RTC_LIB on the file, arch/mips/Kconfig by default? If so all deconfigs may not be modified.

RTC_CLASS implies RTC_LIB. It's not a replacement.

I meas if we use directly RTC_CLASS on the file, arch/mips/Kconfig, as the following:
==
config MIPS
bool
default y
select HAVE_IDE
select HAVE_OPROFILE
select HAVE_ARCH_KGDB
# Horrible source of confusion. Die, die, die ... select EMBEDDED
select RTC_LIB --> RTC_CLASS
===

If so RTC_Class and RTC_HCTOSYS options will be enabled for all platforms by default as you expect. I think it will be given a hint for the developers that they should develop their RTC towards supporting RTC_CLASS in the future, not other choices. And it may be helpful to have an unified RTC mode quickly.

Thanks & Best Regards
Tiejun

Quoted 2 lines

Ralf