add missing cmdset field in PXA3xx NAND code
Subsystems (2)
PATCH 1/1 add missing cmdset field in PXA3xx NAND code
This adds a missing .cmdset parameter for STM 2G NAND chip definition. Even though support for built-in NAND chips is marked deprecated, the driver crashes in __readid() due to a NULL pointer dereference if it's not there.
Signed-off-by Daniel Mack <[email protected]>
drivers/mtd/nand/pxa3xx_nand.c +1 -0
@@ -269,6 +269,7 @@ static struct pxa3xx_nand_timing stm2GbX16_timing = {static struct pxa3xx_nand_flash stm2GbX16 = { .timing = &stm2GbX16_timing, + .cmdset = &largepage_cmdset, .page_per_block =64 , .page_size =2048 , .flash_width =16 ,
Quoted 6 lines · Daniel Mack
This adds a missing .cmdset parameter for STM 2G NAND chip definition. Even though support for built-in NAND chips is marked deprecated, the driver crashes in
__readid()due to a NULL pointer dereference if it's not there.Signed-off-by Daniel Mack <[email protected]>
Thanks, however this is a bit later, some one spotted this earlier:
http://lists.infradead.org/pipermail/linux-mtd/2008-November/023643.html