bluetooth usb hci: ISSC usb dongle with buggy SCO support

PATCH In review Luca Santarelli 4 participants 7 messages Dec 4, 2008 – Dec 9, 2008 Bluetooth drivers

lore

Share & tools

lore

Luca Santarelli

author

2008-12-04 23:02 UTC #0 lore raw

PATCH 1/1 bluetooth usb hci: ISSC usb dongle with buggy SCO support

From: Luca Santarelli <hrk <t> users.sourceforge.net>

As reported at:
http://bugs.gentoo.org/show_bug.cgi?id=249523
and in reference of similar patches such as:
http://thread.gmane.org/gmane.linux.bluez.devel/15067

This patch changes the blacklist entry for the ISSC bluetooth USB dongle fixing the issue of the repeatedly appearing message

hci_scodata_packet: hci0 SCO packet for unknown connection handle 92

in the kernel logs.

Sighed-off-by: Luca Santarelli <hrk <at> users.sourceforge.net>
---
This is my first kernel patch ever, I read the docs, but please notify me if I made any mistake. Thank you all for your work, I'm happy to have been able to contribute to this!

The patch has been run against 2.6.27.7 and has been tested on three x86 machines, showing no issues. In my own tests, the dongle has been then used to connect to devices and everything worked fine.

drivers/bluetooth/hci_usb.c renamed from drivers/bluetooth/hci_usb.c.orig +2 -2

@@ -148,8 +148,8 @@ static struct usb_device_id blacklist_id
 	{ USB_DEVICE(0x047d, 0x105d), .driver_info = HCI_RESET },
 	{ USB_DEVICE(0x047d, 0x105e), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
 
-	/* ISSC Bluetooth Adapter v3.1 */
-	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET },
+	/* ISSC Bluetooth Adapter v3.1 with buggy SCO support */
+	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET | HCI_BROKEN_ISOC },
 
 	/* RTX Telecom based adapters with buggy SCO support */
 	{ USB_DEVICE(0x0400, 0x0807), .driver_info = HCI_BROKEN_ISOC },

Andrew Morton

2008-12-07 08:19 UTC #1 lore raw

Quoted 27 lines · On Fri, 5 Dec 2008 00:02:13 +0100 Luca Santarelli <[email protected]>…

From: Luca Santarelli <hrk <t> users.sourceforge.net>
As reported at:
http://bugs.gentoo.org/show_bug.cgi?id=249523
and in reference of similar patches such as:
http://thread.gmane.org/gmane.linux.bluez.devel/15067
This patch changes the blacklist entry for the ISSC bluetooth USB dongle fixing the issue of the repeatedly appearing message
hci_scodata_packet: hci0 SCO packet for unknown connection handle 92
in the kernel logs.
Sighed-off-by: Luca Santarelli <hrk <at> users.sourceforge.net>
---
This is my first kernel patch ever, I read the docs, but please notify me if I made any mistake. Thank you all for your work, I'm happy to have been able to contribute to this!
The patch has been run against 2.6.27.7 and has been tested on three x86 machines, showing no issues. In my own tests, the dongle has been then used to connect to devices and everything worked fine.

drivers/bluetooth/hci_usb.c static struct usb_device_id blacklist_id · line 155

Quoted 10 lines

drivers/bluetooth/hci_usb.c renamed from drivers/bluetooth/hci_usb.c.orig +2 -2

@@ -148,8 +148,8 @@ static struct usb_device_id blacklist_id
 	{ USB_DEVICE(0x047d, 0x105d), .driver_info = HCI_RESET },
 	{ USB_DEVICE(0x047d, 0x105e), .driver_info = HCI_RESET | HCI_WRONG_SCO_MTU },
 
-	/* ISSC Bluetooth Adapter v3.1 */
-	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET },
+	/* ISSC Bluetooth Adapter v3.1 with buggy SCO support */
+	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET | HCI_BROKEN_ISOC },
 
 	/* RTX Telecom based adapters with buggy SCO support */
 	{ USB_DEVICE(0x0400, 0x0807), .driver_info = HCI_BROKEN_ISOC },

linux-next has:

commit 12421b40b81d101d7535e03f1af197365adc932b

Author: Marcel Holtmann <[email protected]>
Date:   Sun Nov 30 12:17:21 2008 +0100

Bluetooth: Remove deprecated hci_usb driver

The old hci_usb driver has been fully replaced with the new btusb driver and all major distributions switched to the new driver now. This removes it since it should not be used at all anymore.

so please confirm that btusb correctly supports that hardware?

Daniel Drake

2008-12-07 12:58 UTC #2 lore raw

Quoted 11 lines · Andrew Morton

commit 12421b40b81d101d7535e03f1af197365adc932b
Author: Marcel Holtmann <[email protected]>
Date:   Sun Nov 30 12:17:21 2008 +0100
Bluetooth: Remove deprecated hci_usb driver
The old hci_usb driver has been fully replaced with the new btusb driver and all major distributions switched to the new driver now. This removes it since it should not be used at all anymore.
so please confirm that btusb correctly supports that hardware?

And if it doesn't, it should be trivial to come up with an equivalent patch to modify blacklist_table in btusb.

Daniel

Luca Santarelli

author

2008-12-08 23:07 UTC #3 lore raw

In reply to Andrew Morton

Il giorno 07/dic/08, alle ore 09:19, Andrew Morton ha scritto:

Quoted 8 lines

linux-next has:
commit 12421b40b81d101d7535e03f1af197365adc932b
Author: Marcel Holtmann <[email protected]>
Date:   Sun Nov 30 12:17:21 2008 +0100
Bluetooth: Remove deprecated hci_usb driver

Quoted 7 lines

The old hci_usb driver has been fully replaced with the new btusb
driver
and all major distributions switched to the new driver now. This
removes
it since it should not be used at all anymore.
so please confirm that btusb correctly supports that hardware?

Thanks for the heads up! I'll compile the new sources and let you know if it's supported. However, since the hci_usb is being deprecated but not removed, shouldn't the patch be incorporated nonetheless?

Luca

Markos Chandras

2008-12-09 13:49 UTC #4 lore raw

Quoted 21 lines · On Tuesday 09 December 2008 01:07:35 Luca Santarelli wrote:

Il giorno 07/dic/08, alle ore 09:19, Andrew Morton ha scritto:
Quoted 8 lines
linux-next has:
commit 12421b40b81d101d7535e03f1af197365adc932b
Author: Marcel Holtmann <[email protected]>
Date:   Sun Nov 30 12:17:21 2008 +0100
Bluetooth: Remove deprecated hci_usb driver
Quoted 7 lines
The old hci_usb driver has been fully replaced with the new btusb
driver
and all major distributions switched to the new driver now. This
removes
it since it should not be used at all anymore.
so please confirm that btusb correctly supports that hardware?
Thanks for the heads up! I'll compile the new sources and let you know if it's supported. However, since the hci_usb is being deprecated but not removed, shouldn't the patch be incorporated nonetheless?

Quoted 6 lines

Luca
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Seems to work fine on gentoo-sources-2.6.27-r5. Thank you all :)

Signature · 1 line

Markos Chandras

Luca Santarelli

author

2008-12-09 19:22 UTC #5 lore raw

In reply to Luca Santarelli

Il giorno 09/dic/08, alle ore 00:07, Luca Santarelli ha scritto:

Quoted 17 lines

Il giorno 07/dic/08, alle ore 09:19, Andrew Morton ha scritto:
Quoted 14 lines
linux-next has:
commit 12421b40b81d101d7535e03f1af197365adc932b
Author: Marcel Holtmann <[email protected]>
Date:   Sun Nov 30 12:17:21 2008 +0100
Bluetooth: Remove deprecated hci_usb driver
The old hci_usb driver has been fully replaced with the new btusb
driver
and all major distributions switched to the new driver now. This
removes
it since it should not be used at all anymore.

Quoted 6 lines

Quoted 1 line
so please confirm that btusb correctly supports that hardware?
Thanks for the heads up! I'll compile the new sources and let you know if it's supported. However, since the hci_usb is being deprecated but not removed, shouldn't the patch be incorporated nonetheless?
Luca

Ok, I'm back. I compiled the latest sources and the device is recognized and works with the new btusb driver. What about the deprecated driver? Will it be fixed or kept as it is?

Luca

Markos Chandras

2008-12-09 12:31 UTC #6 lore raw

In reply to Andrew Morton

Quoted 1 line · On Sunday 07 December 2008 10:19:53 Andrew Morton wrote:

On Fri, 5 Dec 2008 00:02:13 +0100 Luca Santarelli

Quoted 53 lines · <[email protected]> wrote:

Quoted 38 lines
From: Luca Santarelli <hrk <t> users.sourceforge.net>
As reported at:
http://bugs.gentoo.org/show_bug.cgi?id=249523
and in reference of similar patches such as:
http://thread.gmane.org/gmane.linux.bluez.devel/15067
This patch changes the blacklist entry for the ISSC bluetooth USB dongle fixing the issue of the repeatedly appearing message
hci_scodata_packet: hci0 SCO packet for unknown connection handle 92
in the kernel logs.
Sighed-off-by: Luca Santarelli <hrk <at> users.sourceforge.net>
---
This is my first kernel patch ever, I read the docs, but please notify me if I made any mistake. Thank you all for your work, I'm happy to have been able to contribute to this!
The patch has been run against 2.6.27.7 and has been tested on three x86 machines, showing no issues. In my own tests, the dongle has been then used to connect to devices and everything worked fine.
--- linux-2.6.27.7/drivers/bluetooth/hci_usb.c.orig 2008-12-04
20:18:38.000000000 +0100 +++
linux-2.6.27.7/drivers/bluetooth/hci_usb.c 2008-12-04 20:19:37.000000000
+0100 @@ -148,8 +148,8 @@ static struct usb_device_id blacklist_id
(quoted diff) +0 -0
 	{ USB_DEVICE(0x047d, 0x105d), .driver_info = HCI_RESET },
 	{ USB_DEVICE(0x047d, 0x105e), .driver_info = HCI_RESET |
HCI_WRONG_SCO_MTU },
drivers/bluetooth/hci_usb.c renamed from drivers/bluetooth/hci_usb.c.orig +2 -2
-	/* ISSC Bluetooth Adapter v3.1 */
-	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET },
+	/* ISSC Bluetooth Adapter v3.1 with buggy SCO support */
+	{ USB_DEVICE(0x1131, 0x1001), .driver_info = HCI_RESET |
HCI_BROKEN_ISOC },
drivers/bluetooth/hci_usb.c static struct usb_device_id blacklist_id · line 155
Quoted 2 lines
drivers/bluetooth/hci_usb.c renamed from drivers/bluetooth/hci_usb.c.orig +0 -0
 	/* RTX Telecom based adapters with buggy SCO support */
 	{ USB_DEVICE(0x0400, 0x0807), .driver_info = HCI_BROKEN_ISOC },
linux-next has:
commit 12421b40b81d101d7535e03f1af197365adc932b
Author: Marcel Holtmann <[email protected]>
Date:   Sun Nov 30 12:17:21 2008 +0100
Bluetooth: Remove deprecated hci_usb driver
The old hci_usb driver has been fully replaced with the new btusb
driver and all major distributions switched to the new driver now. This removes it since it should not be used at all anymore.

Quoted 6 lines

so please confirm that btusb correctly supports that hardware? --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Unfortunatelly it doesnt work here. The new driver cant recognize my device. I am using gentoo-sources-2.6.26-r4 ( which means linux-sources-2.6.26-5).

I ll post again my device info from lsusb. I ll try to come up with a patch is possible

Bus 002 Device 002: ID 1131:1001 Integrated System Solution Corp. KY-BT100 Bluetooth Adapter

Thanks

Signature · 1 line

Markos Chandras