Skip to contentSkip to conversation

rfcomm/sock: fix build problem

PATCH In review Alexander Beregalov 2 participants 2 messages Dec 9, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rfcomm/sock: fix build problem

net/bluetooth/rfcomm/sock.c: In function 'rfcomm_sock_ioctl':
net/bluetooth/rfcomm/sock.c:795: error: 'sk' undeclared (first use in this function) net/bluetooth/rfcomm/sock.c:795: error: (Each undeclared identifier is reported only once net/bluetooth/rfcomm/sock.c:795: error: for each function it appears in.)

It is a conflict between a418b893
(Bluetooth: Enable per-module dynamic debug messages) and 45555c0e
(bluetooth: fix warning in net/bluetooth/rfcomm/sock.c)

---

 net/bluetooth/rfcomm/sock.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
net/bluetooth/rfcomm/sock.c +0 -2
index ad00cbf..d63040f 100644
@@ -787,9 +787,7 @@ static int rfcomm_sock_getsockopt(struct socket *sock, int level, int optname, c
 
 static int rfcomm_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
 {
-#if defined(CONFIG_BT_RFCOMM_TTY) || defined(CONFIG_BT_RFCOMM_DEBUG)
 	struct sock *sk = sock->sk;
-#endif
 	int err;
 
 	BT_DBG("sk %p cmd %x arg %lx", sk, cmd, arg);
#1 lore raw

From: Alexander Beregalov <[email protected]>
Date: Tue, 9 Dec 2008 15:39:50 +0300

Quoted 11 lines

net/bluetooth/rfcomm/sock.c: In function 'rfcomm_sock_ioctl':
net/bluetooth/rfcomm/sock.c:795: error: 'sk' undeclared (first use in this function) net/bluetooth/rfcomm/sock.c:795: error: (Each undeclared identifier is reported only once net/bluetooth/rfcomm/sock.c:795: error: for each function it appears in.)

It is a conflict between a418b893
(Bluetooth: Enable per-module dynamic debug messages) and 45555c0e
(bluetooth: fix warning in net/bluetooth/rfcomm/sock.c)

Already fixed in net-next-2.6.

BTW, your patch reintroduces a warning.