Skip to contentSkip to conversation

PCI: Don't carp about BAR allocation failures in quiet boot]

PATCH Jesse Barnes 1 participant 1 message Dec 16, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Thanks for the heads-up, applied this to my linux-next branch.

Jesse

Quoted 65 lines · Ingo Molnar

FYI.

----- Forwarded message from Adam Jackson <[email protected]> -----

Date: Thu, 11 Dec 2008 17:13:45 -0500
From: Adam Jackson <[email protected]>
To: [email protected]
Subject: [PATCH] PCI: Don't carp about BAR allocation failures in quiet boot Cc: Adam Jackson <[email protected]>

These are easy to trigger (more or less harmlessly) with multiple video cards, since the ROM BAR will typically not be given any space by the BIOS bridge setup. No reason to punish quiet boot for this.

---
 arch/x86/pci/i386.c     |    4 ++--
 drivers/pci/setup-res.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/x86/pci/i386.c +0 -0
index 844df0c..43d9783 100644
@@ -129,7 +129,7 @@ static void __init

pcibios_allocate_bus_resources(struct list_head *bus_list) pr = pci_find_parent_resource(dev, r);

arch/x86/pci/i386.c +2 -2
 				if (!r->start || !pr ||
 				    request_resource(pr, r) < 0) {
-					dev_err(&dev->dev, "BAR %d: can't allocate resource\n", idx);
+					dev_info(&dev->dev, "BAR %d: can't allocate resource\n", idx);
 					/*
 					 * Something is wrong with the region.
 					 * Invalidate the resource to prevent
@@ -170,7 +170,7 @@ static void __init pcibios_allocate_resources(int pass)
 					r->flags, disabled, pass);
 				pr = pci_find_parent_resource(dev, r);
 				if (!pr || request_resource(pr, r) < 0) {
-					dev_err(&dev->dev, "BAR %d: can't allocate resource\n", idx);
+					dev_info(&dev->dev, "BAR %d: can't allocate resource\n", idx);
 					/* We'll assign a new address later */
 					r->end -= r->start;
 					r->start = 0;
drivers/pci/setup-res.c +2 -2
index 2dbd96c..4e37563 100644
@@ -134,7 +134,7 @@ int pci_assign_resource(struct pci_dev *dev, int resno)
 
 	align = resource_alignment(res);
 	if (!align) {
-		dev_err(&dev->dev, "BAR %d: can't allocate resource (bogus "
+		dev_info(&dev->dev, "BAR %d: can't allocate resource (bogus "
 			"alignment) %pR flags %#lx\n",
 			resno, res, res->flags);
 		return -EINVAL;
@@ -157,7 +157,7 @@ int pci_assign_resource(struct pci_dev *dev, int resno)
 	}
 
 	if (ret) {
-		dev_err(&dev->dev, "BAR %d: can't allocate %s resource %pR\n",
+		dev_info(&dev->dev, "BAR %d: can't allocate %s resource %pR\n",
 			resno, res->flags & IORESOURCE_IO ? "I/O" : "mem", res);
 	} else {
 		res->flags &= ~IORESOURCE_STARTALIGN;
Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center