Skip to contentSkip to conversation

add MIME-aware footers

PATCH In review Gerd v. Egidy 4 participants 8 messages Dec 14, 2008 – Feb 18, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add MIME-aware footers

Hi,

I've been bitten by the footer-function not being MIME-aware. I've read up the topic on the list-archive and found out that I'm not the only one and that a solution has to be separatable from the core mlmmj.

I found the altermime program (http://www.pldaniels.com/altermime/) which seems to be a perfect match for the MIME-munging required. So I wrote a small shell script to integrate altermime and mlmmj.

How to use it:

- install altermime to /usr/bin/altermime
- copy the attached mlmmj-amime-receive into /usr/bin
- put the footer-text for the different MIME-types into control/amime-footer-text
control/amime-footer-html
control/amime-footer-base64
- replace mlmmj-recieve with mlmmj-amime-receive in /etc/aliases, e.g.
myml: "|/usr/bin/mlmmj-amime-receive -L /var/spool/mlmmj/myml/"
watch out for recieve vs. receive...
- newaliases

Morten, I hope this solution is acceptable for inclusion into mlmmj. I attached mlmmj-amime.patch too, this is intended for you and adds mlmmj-amime- receive into contrib.

Kind regards,

Gerd

contrib/Makefile.am +2 -0
diff -r -u -N mlmmj-1.2.16-RC1.orig/contrib/Makefile.am mlmmj-1.2.16-RC1/contrib/Makefile.am
@@ -2,3 +2,5 @@
 
 EXTRA_DIST = web
 SUBDIRS = recievestrip
+
+bin_SCRIPTS = mlmmj-amime-receive
contrib/mlmmj-amime-receive +89 -0

89 lines not on this page · raw message

#1 lore raw
Quoted 24 lines · On Sun, 14 Dec 2008 01:23:12 +0100 "Gerd v. Egidy" <[email protected]> wrote:

Hi,

I've been bitten by the footer-function not being MIME-aware. I've read up the topic on the list-archive and found out that I'm not the only one and that a solution has to be separatable from the core mlmmj.

I found the altermime program (http://www.pldaniels.com/altermime/)
which seems to be a perfect match for the MIME-munging required. So I wrote a small shell script to integrate altermime and mlmmj.

How to use it:

- install altermime to /usr/bin/altermime
- copy the attached mlmmj-amime-receive into /usr/bin
- put the footer-text for the different MIME-types into control/amime-footer-text
control/amime-footer-html
control/amime-footer-base64
- replace mlmmj-recieve with mlmmj-amime-receive in /etc/aliases, e.g.
myml: "|/usr/bin/mlmmj-amime-receive -L /var/spool/mlmmj/myml/"
watch out for recieve vs. receive...
- newaliases

Quoted 8 lines

Morten, I hope this solution is acceptable for inclusion into mlmmj. I attached mlmmj-amime.patch too, this is intended for you and adds mlmmj-amime- receive into contrib.

Kind regards,

Gerd

Nice! This seems totally non-intrusive and changes nothing for existing users, so I vote for this inclusion into contrib (together with a readme). A small remark: since the paths for /usr/bin/altermime and mlmmj-amime-receive can be different than the ones mentioned above, you should probably say :
"- install altermime to /usr/bin/altermime or change the path in the file contrib/mlmmj-amime-receive"
"- check the path of mlmmj-recieve at the top of the file contrib/mlmmj-amime-receive"

(since the shell script already has these as parameters, you might as well advertise it :-) )

Franky

#2 lore raw

PATCH 1/1 add MIME-aware footers

In reply to Gerd v. Egidy

Hi,

this patch has already been sent in dec 2008 to this ml but was not yet applied. I guess it was forgotten.

The patch allows adding footers to different MIME-types. It uses altermime to add the footers before giving the mail to the regular mlmmj-functions. Mlmmj itself doesn't need to be changed to use this.

How to use it:

- install altermime to /usr/bin/altermime
- copy the mlmmj-amime-receive from the contrib-dir into /usr/bin
- put the footer-text for the different MIME-types into control/amime-footer-text
control/amime-footer-html
control/amime-footer-base64
- replace mlmmj-recieve with mlmmj-amime-receive in /etc/aliases, e.g.
myml: "|/usr/bin/mlmmj-amime-receive -L /var/spool/mlmmj/myml/"
watch out for recieve vs. receive...
- newaliases

If this patch is not acceptable in its current form or missing something please speak up.

Kind regards,

Gerd

Signature · 2 lines
Address (better: trap) for people I really don't want to get mail from:
[email protected]
contrib/Makefile.am +2 -0
diff -r -u -N mlmmj-1.2.16-RC1.orig/contrib/Makefile.am mlmmj-1.2.16-RC1/contrib/Makefile.am
@@ -2,3 +2,5 @@
 
 EXTRA_DIST = web
 SUBDIRS = recievestrip
+
+bin_SCRIPTS = mlmmj-amime-receive
contrib/mlmmj-amime-receive +89 -0

89 lines not on this page · raw message

#3 lore raw

PATCH 1/1 add MIME-aware footers

In reply to Gerd v. Egidy

Hi Morten,

this patch has already been sent in dec 2008 and jan 2010 to this ml but was not yet applied. I guess it was forgotten. You said something about pestering you until you commited it. So here I am...

The patch allows adding footers to different MIME-types. It uses altermime to add the footers before giving the mail to the regular mlmmj-functions. Mlmmj itself doesn't need to be changed to use this.

How to use it:

- install altermime to /usr/bin/altermime
- copy the mlmmj-amime-receive from the contrib-dir into /usr/bin
- put the footer-text for the different MIME-types into control/amime-footer-text
control/amime-footer-html
control/amime-footer-base64
- replace mlmmj-recieve with mlmmj-amime-receive in /etc/aliases, e.g.
myml: "|/usr/bin/mlmmj-amime-receive -L /var/spool/mlmmj/myml/"
watch out for recieve vs. receive...
- newaliases

If this patch is not acceptable in its current form or missing something please speak up.

Kind regards,

Gerd

Signature · 2 lines
Address (better: trap) for people I really don't want to get mail from:
[email protected]
contrib/Makefile.am +2 -0
diff -r -u -N mlmmj-1.2.16-RC1.orig/contrib/Makefile.am mlmmj-1.2.16-RC1/contrib/Makefile.am
@@ -2,3 +2,5 @@
 
 EXTRA_DIST = web
 SUBDIRS = recievestrip
+
+bin_SCRIPTS = mlmmj-amime-receive
contrib/mlmmj-amime-receive +89 -0

89 lines not on this page · raw message

#4 lore raw
In reply to Gerd v. Egidy

Hi Gerd,

Quoted 2 lines · Gerd v. Egidy

this patch has already been sent in dec 2008 and jan 2010 to this ml but was not yet applied. I guess it was forgotten.

Not forgotten, but I am still working my way through January's mail.

Quoted 2 lines

You said something about pestering you until you commited it. So here I am...

I really appreciate your patience with me.

Quoted 3 lines

The patch allows adding footers to different MIME-types. It uses altermime to add the footers before giving the mail to the regular mlmmj-functions. Mlmmj itself doesn't need to be changed to use this.

Thanks a lot. I've committed it to CVS now, and it will be included in the next release.

Morten

Signature · 3 lines
Morten Shearman Kirkegaard <[email protected]>
CTO, FableTech
http://fabletech.com/
#5 lore raw
In reply to Gerd v. Egidy

Hi Morten,

Quoted 4 lines
Quoted 2 lines

You said something about pestering you until you commited it. So here I am...

I really appreciate your patience with me.

no worries, I know how it is to maintain an open source project and often lag in responding too.

Quoted 6 lines
Quoted 3 lines

The patch allows adding footers to different MIME-types. It uses altermime to add the footers before giving the mail to the regular mlmmj-functions. Mlmmj itself doesn't need to be changed to use this.

Thanks a lot. I've committed it to CVS now, and it will be included in the next release.

Thank you.

BTW, is the CVS available to the public somewhere?

Kind regards,

Gerd

Signature · 2 lines
Address (better: trap) for people I really don't want to get mail from:
[email protected]
#6 lore raw
In reply to Gerd v. Egidy
Quoted 1 line · Gerd v. Egidy

BTW, is the CVS available to the public somewhere?

Not at the moment, but if you drop Mads Martin a mail, you might be able to convince him to create an account for you.

Morten

Signature · 3 lines
Morten Shearman Kirkegaard <[email protected]>
CTO, FableTech
http://fabletech.com/
#7 lore raw
In reply to Gerd v. Egidy
Quoted 4 lines · Morten Shearman Kirkegaard
Quoted 1 line

BTW, is the CVS available to the public somewhere?

Not at the moment, but if you drop Mads Martin a mail, you might be able to convince him to create an account for you.

I would much rather someone converted it to something and put it somewhere :)

Signature · 4 lines
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                 -- A. P. J.