Skip to contentSkip to conversation

SEND_SIG_NOINFO: Masquerade si_pid when crossing pid-ns boundary

RFC PATCH In review Sukadev Bhattiprolu 2 participants 2 messages Dec 17, 2008

lore
Share & tools
lore

Sukadev Bhattiprolu

author
#0 lore raw

RFC PATCH v2 1/1 SEND_SIG_NOINFO: Masquerade si_pid when crossing pid-ns boundary

From: Sukadev Bhattiprolu <[email protected]>
Date: Fri, 12 Dec 2008 17:51:43 -0800
Subject: [PATCH] SEND_SIG_NOINFO: Masquerade si_pid when crossing pid-ns boundary

For SEND_SIG_NOINFO, si_pid is currently set to the pid of sender in sender's active pid namespace. But if the receiver is in a different namespace, that given pid number would be incorrect.
Eg: when parent sends the 'pdeath_signal' to a child that is in a descendant pid namespace, we should set si_pid 0.

Changelog[v2]
- Moved change from task_pid() to task_tgid() to separate patch

Signed-off-by Sukadev Bhattiprolu <[email protected]>
---
 kernel/signal.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/signal.c +2 -1
index 2a64304..d11e5f8 100644
@@ -856,7 +856,8 @@ static int send_signal(int sig, struct siginfo *info, struct task_struct *t,
 			q->info.si_signo = sig;
 			q->info.si_errno = 0;
 			q->info.si_code = SI_USER;
-			q->info.si_pid = task_pid_vnr(current);
+			q->info.si_pid = task_pid_nr_ns(current,
+							task_active_pid_ns(t));
 			q->info.si_uid = current_uid();
 			break;
 		case (unsigned long) SEND_SIG_PRIV:
Signature · 1 line
1.5.2.5