Skip to contentSkip to conversation

net: ppp_generic - use DEFINE_IDR for static initialization

PATCH Applied Cyrill Gorcunov 2 participants 2 messages Dec 18, 2008 – Dec 19, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Cyrill Gorcunov

author
#0 lore raw

PATCH 1/1 net: ppp_generic - use DEFINE_IDR for static initialization

Please review.

---

Quoted 1 line

From 17bbdd601fc1be761876165488879def4649c968 Mon Sep 17 00:00:00 2001

From: Cyrill Gorcunov <[email protected]>
Date: Thu, 18 Dec 2008 18:41:42 +0300
Subject: [PATCH] net: ppp_generic - use DEFINE_IDR for static initialization

We could use DEFINE_IDR for statically allocated idr that allow us to save a few lines of code.

And spell fix.

CC Andrew Morton <[email protected]>
CC David Miller <[email protected]>
Signed-off-by Cyrill Gorcunov <[email protected]>
---
 drivers/net/ppp_generic.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
drivers/net/ppp_generic.c +2 -4
index 293e1c4..b13e600 100644
@@ -178,7 +178,7 @@ struct channel {
  */
 static DEFINE_MUTEX(all_ppp_mutex);
 static atomic_t ppp_unit_count = ATOMIC_INIT(0);
-static struct idr ppp_units_idr;
+static DEFINE_IDR(ppp_units_idr);
 
 /*
  * all_channels_lock protects all_channels and last_channel_index,

@@ -841,8 +841,6 @@ static int __init ppp_init(void)
 		device_create(ppp_class, NULL, MKDEV(PPP_MAJOR, 0), "ppp");
 	}
 
-	idr_init(&ppp_units_idr);
-
 out:
 	if (err)
 		printk(KERN_ERR "failed to register PPP device (%d)\n", err);

@@ -2426,7 +2424,7 @@ ppp_create_interface(int unit, int *retp)
 		if (unit_find(&ppp_units_idr, unit))
 			goto out2; /* unit already exists */
 		else {
-			/* darn, someone is cheatting us? */
+			/* darn, someone is cheating us? */
 			*retp = -EINVAL;
 			goto out2;
 		}
Signature · 1 line
1.6.0.4.603.gbc9c0
maintainer Applied
#1 lore raw

From: Cyrill Gorcunov <[email protected]>
Date: Thu, 18 Dec 2008 18:46:36 +0300

Quoted 8 lines

net: ppp_generic - use DEFINE_IDR for static initialization

We could use DEFINE_IDR for statically allocated idr that allow us to save a few lines of code.

And spell fix.

Signed-off-by Cyrill Gorcunov <[email protected]>

Applied, thank you.