Skip to contentSkip to conversation

Allow dependancies of FDDI & Tokenring to be modular.

PATCH Applied Dave Jones 2 participants 2 messages Dec 26, 2008 – Dec 28, 2008

Subsystems (2)
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

PATCH 1/1 Allow dependancies of FDDI & Tokenring to be modular.

I noticed it isn't possible to build token ring & fddi drivers without causing LLC, and a bunch of other things to be forced built-in. For distro kernels, this means carrying a chunk of code in the vmlinuz, even if the user doesn't use those protocols.

Signature · 29 lines
I don't have any hardware for either of these, so I'm unable to test
if it actually works or not, but seeing as the bits in net/ all have
module_init's, it seems they were meant to be allowed to be built this way.

--- linux-2.6.28.noarch/drivers/net/Kconfig~	2008-12-25 23:28:55.000000000 -0500
+++ linux-2.6.28.noarch/drivers/net/Kconfig	2008-12-25 23:29:09.000000000 -0500
@@ -2637,7 +2637,7 @@ config RIONET_RX_SIZE
 	default "128"
 
 config FDDI
-	bool "FDDI driver support"
+	tristate "FDDI driver support"
 	depends on (PCI || EISA || TC)
 	help
 	  Fiber Distributed Data Interface is a high speed local area network
--- linux-2.6.28.noarch/drivers/net/tokenring/Kconfig~	2008-12-25 23:54:29.000000000 -0500
+++ linux-2.6.28.noarch/drivers/net/tokenring/Kconfig	2008-12-25 23:54:34.000000000 -0500
@@ -4,7 +4,7 @@
 
 # So far, we only have PCI, ISA, and MCA token ring devices
 menuconfig TR
-	bool "Token Ring driver support"
+	tristate "Token Ring driver support"
 	depends on NETDEVICES && !UML
 	depends on (PCI || ISA || MCA || CCW)
 	select LLC

-- 
http://www.codemonkey.org.uk
maintainer Applied
#1 lore raw

From: Dave Jones <[email protected]>
Date: Fri, 26 Dec 2008 16:52:51 -0500

Quoted 6 lines

I noticed it isn't possible to build token ring & fddi drivers without causing LLC, and a bunch of other things to be forced built-in. For distro kernels, this means carrying a chunk of code in the vmlinuz, even if the user doesn't use those protocols.

Looks good.

Applied, thanks Dave.