Skip to contentSkip to conversation

wifi: iwlwifi: fix documentation about initial values in station table

PATCH Rolf Eike Beer 2 participants 2 messages Dec 19, 2024 Intel wireless wifi link (iwlwifi)

lore
Share & tools
lore

Rolf Eike Beer

author
#0 lore raw

The inverse value is stored in the table, make the documentation match the code.

Signed-off-by Rolf Eike Beer <[email protected]>
---
 drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/mvm/sta.h +1 -1
index 4a3799ae7c18..dbc531c63f0f 100644
@@ -133,7 +133,7 @@ struct iwl_mvm_vif;
  * and no TID data as this is also not needed.
  * One thing to note, is that these stations have an ID in the fw, but not
  * in mac80211. In order to "reserve" them a sta_id in %fw_id_to_mac_id
- * we fill ERR_PTR(EINVAL) in this mapping and all other dereferencing of
+ * we fill ERR_PTR(-EINVAL) in this mapping and all other dereferencing of
  * pointers from this mapping need to check that the value is not error
  * or NULL.
  *
Signature · 17 lines
2.47.1


-- 
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail [email protected]
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner
maintainer Acked-by
#1 lore raw
Quoted 47 lines

-----Original Message-----
From: Rolf Eike Beer <[email protected]>
Sent: Thursday, 19 December 2024 12:22
To: Korenblit, Miriam Rachel <[email protected]>
Cc: [email protected]; [email protected]
Subject: wifi: iwlwifi: fix documentation about initial values in station table

The inverse value is stored in the table, make the documentation match the code.

Signed-off-by Rolf Eike Beer <[email protected]>
---
 drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/mvm/sta.h +1 -2
index 4a3799ae7c18..dbc531c63f0f 100644
@@ -133,7 +133,7 @@ struct iwl_mvm_vif;
  * and no TID data as this is also not needed.
  * One thing to note, is that these stations have an ID in the fw, but not
  * in mac80211. In order to "reserve" them a sta_id in %fw_id_to_mac_id
- * we fill ERR_PTR(EINVAL) in this mapping and all other dereferencing of
+ * we fill ERR_PTR(-EINVAL) in this mapping and all other dereferencing of
  * pointers from this mapping need to check that the value is not error
  * or NULL.
  *
--

2.47.1

--
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany Phone +49 (0)551 30664-0, e-mail [email protected] District Court of Göttingen, Registry Number HR B 3160 Managing Directors: Heike Jordan, Dr. Uwe Kracke VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

Quoted 2 lines

emlix - your embedded Linux partner

Acked-by Miri Korenblit <[email protected]>