Skip to contentSkip to conversation

Missing v4l2_prio_close in radio_release

PATCH New Udo A. Steinberg 1 participant 1 message Jan 2, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Missing v4l2_prio_close in radio_release

The radio_release function of the BTTV driver is missing a call to v4l2_prio_close. As a result, after the radio device has been opened at least once (e.g., by HAL during bootup), v4l2_priority will never drop below V4L2_PRIORITY_INTERACTIVE again. With the following patch against 2.6.28, applications that run with V4L2_PRIORITY_BACKGROUND are able to open devices again. Previous Linux versions are affected as well.

drivers/media/video/bt8xx/bttv-driver.new renamed from drivers/media/video/bt8xx/bttv-driver.c +1 -0
@@ -3473,6 +3474,7 @@
 	struct bttv *btv = fh->btv;
 	struct rds_command cmd;
 
+	v4l2_prio_close(&btv->prio,&fh->prio);
 	file->private_data = NULL;
 	kfree(fh);