stb6100: stb6100_init fix
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH RESEND 1/1 stb6100: stb6100_init fix
Quoted 32 lines
Quoted 9 lines
Hi Mauro,
please look at the patch below.Signed-off-by Hans Werner <[email protected]>Thanks,
HansQuoted 7 lines
-------- Original-Nachricht --------
Datum: Mon, 05 Jan 2009 16:10:50 +0100
Von: "Hans Werner" <[email protected]>
An: [email protected]
Betreff: [linux-dvb] [PATCH] stb6100:stb6100_initfixTwo issues in
stb6100_init: the call tostb6100_set_bandwidthneeds anargument in Hz
Quoted 1 line
not kHz, and a comment incorrectly says MHz instead of Hz. I don't know
if this caused
Quoted 3 lines
real problems anywhere.
This patch is for v4l-dvb, but it is also needs to be fixed in
s2-liplianin.
Quoted 3 lines
...
...Considering that the ioctl use "state" instead of "status", your patch looks
sane:case
DVBFE_TUNER_BANDWIDTH:
Quoted 8 lines
stb6100_set_bandwidth(fe, state->bandwidth);Could you please re-send this patch to me, mentioning the above, explicitly C/C
Manu, linux-media and linux-dvb ML's? Please, mark the patch as a resend.Cheers,
Mauro
Resending the following patch as requested by Mauro.
linux/drivers/media/dvb/frontends/stb6100.c +2 -2
@@ -434,11 +434,11 @@ static int stb6100_init(struct dvb_front status->refclock =27000000 ;/* Hz */ status->iqsense =1 ; status->bandwidth =36000 ;/* kHz */ - state->bandwidth = status->bandwidth *1000 ;/* MHz */ + state->bandwidth = status->bandwidth *1000 ;/* Hz */ state->reference = status->refclock /1000 ;/* kHz */ /* Set default bandwidth. */ -return stb6100_set_bandwidth (fe, status->bandwidth); +return stb6100_set_bandwidth (fe, state->bandwidth); } static int stb6100_get_state(struct dvb_frontend *fe,
Signature · 9 lines
Release early, release often. Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger _______________________________________________ linux-dvb users mailing list For V4L/DVB development, please use instead [email protected] [email protected] http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Quoted 12 lines · Hans Werner
Signed-off-by Hans Werner <[email protected]>diff -r
b7e7abe3e3aalinux/drivers/media/dvb/frontends/stb6100.clinux/drivers/media/dvb/frontends/stb6100.c +0
-0@@ -434,11 +434,11 @@ static int stb6100_init(struct dvb_front status->refclock =27000000 ;/* Hz */ status->iqsense =1 ; status->bandwidth =36000 ;/* kHz */
linux/drivers/media/dvb/frontends/stb6100.c static int stb6100_init(struct dvb_front · line 444
Quoted 10 lines
linux/drivers/media/dvb/frontends/stb6100.c +2
-2- state->bandwidth = status->bandwidth *1000 ;/* MHz */ + state->bandwidth = status->bandwidth *1000 ;/* Hz */ state->reference = status->refclock /1000 ;/* kHz */ /* Set default bandwidth. */ -return stb6100_set_bandwidth (fe, status->bandwidth); +return stb6100_set_bandwidth (fe, state->bandwidth); } static int stb6100_get_state(struct dvb_frontend *fe,
Patch looks more or less ok, but it won't have any effect in any manner at all as it is a
NOP during init (purely cosmetic). Anyway will pull it in along with the other patches
and after testing.
Manu
_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead [email protected] [email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb