Fixed BSSID step 1: Disallow to set multicast BSSID

Okay, here is the first of the five patches. After applying all of them you should be able to build/join huge city mesh networks (e.g. with the OLSR protocol) with the most of the mac80211 wireless drivers by setting a fixed BSSID in the ad hoc mode. (If you found no other bug/problem.) This was not specified in the original standard, but is a widely used de facto standard.

The first patch now completely disallow to set multicast MAC addresses as BSSID. The behavior before was really strange.

Signed-off-by Alina Friedrichsen <[email protected]>

diff -urN compat-wireless-2009-01-05.orig/net/mac80211/mlme.c compat-wireless-2009-01-05.work/net/mac80211/mlme.c

net/mac80211/mlme.c +7 -2

@@ -2576,11 +2576,16 @@
 {
 	struct ieee80211_if_sta *ifsta;
 	int res;
+	bool valid;
 
 	ifsta = &sdata->u.sta;
+	valid = is_valid_ether_addr(bssid);
 
 	if (memcmp(ifsta->bssid, bssid, ETH_ALEN) != 0) {
-		memcpy(ifsta->bssid, bssid, ETH_ALEN);
+		if(valid)
+			memcpy(ifsta->bssid, bssid, ETH_ALEN);
+		else
+			memset(ifsta->bssid, 0, ETH_ALEN);
 		res = 0;
 		/*
 		 * Hack! See also ieee80211_sta_set_ssid.

@@ -2594,7 +2599,7 @@
 		}
 	}
 
-	if (is_valid_ether_addr(bssid))
+	if (valid)
 		ifsta->flags |= IEEE80211_STA_BSSID_SET;
 	else
 		ifsta->flags &= ~IEEE80211_STA_BSSID_SET;

These look ok to me, with proper changelogs. Thanks. You should have made the subjects
=20
[PATCH 1/5] mac80211: Disallow ...
=20
etc. and also line-wrapped the changelogs, since these are fed direct=

into git normally.

Hello Johannes!

Quoted 7 lines

These look ok to me, with proper changelogs. Thanks. You should have made the subjects

[PATCH 1/5] mac80211: Disallow ...

etc. and also line-wrapped the changelogs, since these are fed directly into git normally.

Okay, but can I do this with the next patches and not repost all this again?

Is there somewhere a git repository, with all the new patches merged? So that I have link where other people can download easily the newest version and test it, to maybe look for other problem in the ad hoc mode, before it is in compat-wireless.

Quoted 4 lines · Alina Friedrichsen

Is there somewhere a git repository, with all the new patches merged? So that I have link where other people can download easily the newest version and test it, to maybe look for other problem in the ad hoc mode, before it is in compat-wireless.

well, wireless-testing, but compat-wireless is updated nightly, iirc.

I'll leave that to John to answer, he gets to do the work if you don't repost.

well, wireless-testing, but compat-wireless is updated nightly, iirc.

Alina, check this guide out, it may help you to post your patches:
=20
http://wireless.kernel.org/en/developers/Documentation/git-guide

Is there somewhere a git repository, with all the new patches merged? So that I have link where other people can download easily the newest version and test it, to maybe look for other problem in the ad hoc mode, before it is in compat-wireless.