sg_io: don't perform unneeded copy in compat code

PATCH In review [email protected] 1 participant 1 message Jan 9, 2009

Subsystems (2)

VFS SCSI

lore

Share & tools

lore

[email protected]

author

2009-01-09 20:36 UTC #0 lore raw

PATCH 11/11 sg_io: don't perform unneeded copy in compat code

From: Alexey Zaytsev <[email protected]>

FUJITA Tomonori says:

The members from 'status' in struct sg_io_hdr to the last are used to transfer information from kernel to user space. The values that user space sets are just ignored.

Signed-off-by Alexey Zaytsev <[email protected]>

Cc FUJITA Tomonori <[email protected]>

Cc Douglas Gilbert <[email protected]>

Cc James Bottomley <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

---

 fs/compat_ioctl.c |    6 ------
 1 file changed, 6 deletions(-)

fs/compat_ioctl.c renamed from fs/compat_ioctl.c~sg_io-dont-perform-unneeded-copy-in-compat-code +0 -6

diff -puN fs/compat_ioctl.c~sg_io-dont-perform-unneeded-copy-in-compat-code fs/compat_ioctl.c
@@ -782,12 +782,6 @@ static int sg_ioctl_trans(unsigned int f
 	if (put_user(compat_ptr(data), &sgio->usr_ptr))
 		return -EFAULT;
 
-	if (copy_in_user(&sgio->status, &sgio32->status,
-			 (4 * sizeof(unsigned char)) +
-			 (2 * sizeof(unsigned (short))) +
-			 (3 * sizeof(int))))
-		return -EFAULT;
-
 	err = sys_ioctl(fd, cmd, (unsigned long) sgio);
 
 	if (err >= 0) {