Skip to contentSkip to conversation

hwmon: (abituguru3) Fix CONFIG_DMI=n fallback

PATCH Applied Alistair John Strachan 2 participants 2 messages Jan 15, 2009

Subsystems (2)
Hardware monitoring Abit uguru 3 hardware monitor driver
lore
Share & tools
lore

Alistair John Strachan

author maintainer
#0 lore raw

PATCH 1/1 hwmon: (abituguru3) Fix CONFIG_DMI=n fallback

When CONFIG_DMI is not enabled, dmi detection should flag that no board could be detected (err=1) rather than another error condition (err<0).

This fixes the fallback to manual probing for all motherboards, even those without DMI strings, when CONFIG_DMI=n.

Signed-off-by Alistair John Strachan <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Jean Delvare <[email protected]>
---
 drivers/hwmon/abituguru3.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/hwmon/abituguru3.c +1 -1
index 70bb854..fcf74eb 100644
@@ -1153,7 +1153,7 @@ static int __init abituguru3_dmi_detect(void)
 
 static inline int abituguru3_dmi_detect(void)
 {
-	return -ENODEV;
+	return 1;
 }
 
 #endif /* CONFIG_DMI */
Signature · 7 lines
Cheers,
Alistair.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Applied
#1 lore raw

Re: [lm-sensors] [PATCH] hwmon: (abituguru3) Fix CONFIG_DMI=n

Quoted 19 lines · Alistair John Strachan

When CONFIG_DMI is not enabled, dmi detection should flag that no board could be detected (err=1) rather than another error condition (err<0).

This fixes the fallback to manual probing for all motherboards, even those without DMI strings, when CONFIG_DMI=n.

Signed-off-by Alistair John Strachan <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Jean Delvare <[email protected]>
---
 drivers/hwmon/abituguru3.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/hwmon/abituguru3.c +0 -0
index 70bb854..fcf74eb 100644

drivers/hwmon/abituguru3.c static int __init abituguru3_dmi_detect(void) · line 1159

Quoted 8 lines
drivers/hwmon/abituguru3.c +1 -1
@@ -1153,7 +1153,7 @@ static int __init abituguru3_dmi_detect(void)
 
 static inline int abituguru3_dmi_detect(void)
 {
-	return -ENODEV;
+	return 1;
 }
 
 #endif /* CONFIG_DMI */

Applied, thanks.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors