Skip to contentSkip to conversation

gpiolib: request fix V2

PATCH In review Magnus Damm 2 participants 2 messages Jan 16, 2009 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpiolib: request fix V2

From: Magnus Damm <[email protected]>

Fix request related issue in gpiolib:
- fix request-already-requested handling in gpio_request()

---

Changes since V1:
- dropped the gpio_direction_input/output fixes

 drivers/gpio/gpiolib.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpiolib.c +1 -0
@@ -789,6 +789,7 @@ int gpio_request(unsigned gpio, const ch
 	} else {
 		status = -EBUSY;
 		module_put(chip->owner);
+		goto done;
 	}
 
 	if (chip->request) {
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Fix request related issue in gpiolib:
- fix request-already-requested handling in gpio_request()

Appropriate for 2.6.28-stable.

Quoted 20 lines

---

Changes since V1:
- dropped the gpio_direction_input/output fixes

 drivers/gpio/gpiolib.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpiolib.c +1 -0
@@ -789,6 +789,7 @@ int gpio_request(unsigned gpio, const ch
 	} else {
 		status = -EBUSY;
 		module_put(chip->owner);
+		goto done;
 	}
 
 	if (chip->request) {