Skip to contentSkip to conversation

hwmon: (f71882fg) Hide misleading error message

PATCH In review Jean Delvare 2 participants 2 messages Jan 19, 2009 – Jan 20, 2009 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (f71882fg) Hide misleading error message

From: Jean Delvare <[email protected]>
Subject: hwmon: (f71882fg) Hide misleading error message

If the F71882FG chip is at address 0x4e, then the probe at 0x2e will fail with the following message in the logs:
f71882fg: Not a Fintek device

This is misleading because there is a Fintek device, just at a different address. So I propose to degrade this message to a debug message.

---
 drivers/hwmon/f71882fg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/f71882fg.c +1 -1
@@ -1872,7 +1872,7 @@ static int __init f71882fg_find(int sioa
 
 	devid = superio_inw(sioaddr, SIO_REG_MANID);
 	if (devid != SIO_FINTEK_ID) {
-		printk(KERN_INFO DRVNAME ": Not a Fintek device\n");
+		pr_debug(DRVNAME ": Not a Fintek device\n");
 		goto exit;
 	}
 
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Acked-by on v1 1/1
#1 lore raw

Re: [lm-sensors] [PATCH] hwmon: (f71882fg) Hide misleading error

Quoted 7 lines · Jean Delvare

From: Jean Delvare <[email protected]>
Subject: hwmon: (f71882fg) Hide misleading error message

If the F71882FG chip is at address 0x4e, then the probe at 0x2e will fail with the following message in the logs:
f71882fg: Not a Fintek device

Quoted 6 lines

This is misleading because there is a Fintek device, just at a different address. So I propose to degrade this message to a debug message.

Looks good to me

Quoted 9 lines
---
 drivers/hwmon/f71882fg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/hwmon/f71882fg.c static int __init f71882fg_find(int sioa · line 1878

Quoted 8 lines
drivers/hwmon/f71882fg.c +1 -1
@@ -1872,7 +1872,7 @@ static int __init f71882fg_find(int sioa
 
 	devid = superio_inw(sioaddr, SIO_REG_MANID);
 	if (devid != SIO_FINTEK_ID) {
-		printk(KERN_INFO DRVNAME ": Not a Fintek device\n");
+		pr_debug(DRVNAME ": Not a Fintek device\n");
 		goto exit;
 	}
 

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors