Skip to contentSkip to conversation

xfsprogs: update doc/CHANGES

PATCH In review Christoph Hellwig 2 participants 5 messages Jan 23, 2009 – Jan 24, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfsprogs: update doc/CHANGES

doc/CHANGES +9 -1
Index: xfsprogs-dev/doc/CHANGES
===================================================================
@@ -1,7 +1,15 @@
 xfsprogs-3.0.0
+	- Various smaller xfs_repair improvements
+	- Various gettext improvements, thanks to Jakub Bogusz
+	- Polish translation update, thanks to Jakub Bogusz
+	- Various xfs_quta fixes, thanks to Arkadiusz Miskiewicz
+	- Support parallel builds
+	- Detection of btrfs, gfs and gfs2 in libdisk
+	- Addition of the xfs_fsr and xfs_estimate tools previous found
+	  in the xfsdump package
 	- Resync libxfs to latest kernel implemenation
 	- Update all of xfsprogs to latest kernel interfaces
-	- Add sparse support to xfsprogs build (thanks to Christoph Hellwig)
+	- Add sparse support to xfsprogs build
 	- Cleanup devel package for xfsctl, libhandle and libdisk only
 	  (remove libxfs interfaces).
 

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw

doc/CHANGES line 5

Quoted 3 lines · Christoph Hellwig
doc/CHANGES +1 -0
+	- Various xfs_quta fixes, thanks to Arkadiusz Miskiewicz

typo.

doc/CHANGES line 9

Quoted 2 lines
doc/CHANGES +2 -0
+	- Addition of the xfs_fsr and xfs_estimate tools previous found
+	  in the xfsdump package

rpm magic is probably needed in build/rpm/rpm.spec.in to prevent old versions of xfsdump from being installed alongside the new xfsprogs ... else rpm will report file conflicts, I think? Same will be needed in debian/control... hmm, both should be pretty easy - just change "Conflicts: xfsdump < 2.0.0" to "3.0.0" (and we should make xfsdump v3 at this time too, so its very clear).

Else, all looks good.

cheers.

--
Nathan

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 7 lines · Nathan Scott

doc/CHANGES line 5

Quoted 3 lines · Christoph Hellwig
doc/CHANGES +1 -0
+	- Various xfs_quta fixes, thanks to Arkadiusz Miskiewicz

typo.

Quoted 9 lines

doc/CHANGES line 9

Quoted 2 lines
doc/CHANGES +2 -0
+	- Addition of the xfs_fsr and xfs_estimate tools previous found
+	  in the xfsdump package

rpm magic is probably needed in build/rpm/rpm.spec.in to prevent old versions of xfsdump from being installed alongside the new xfsprogs ... else rpm will report file conflicts, I think? Same will be needed in debian/control... hmm, both should be pretty easy - just change "Conflicts: xfsdump < 2.0.0" to "3.0.0" (and we should make xfsdump v3 at this time too, so its very clear).

Agreed. I think it's better to leave the debian part to you, and I'll look into the rpm part later.

Any chance you could also review the fsr and estimate manpage patches as they should go in before this one?

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#3 lore raw
Quoted 10 lines · Christoph Hellwig
Quoted 9 lines

doc/CHANGES line 9

Quoted 2 lines
doc/CHANGES +2 -0
+	- Addition of the xfs_fsr and xfs_estimate tools previous found
+	  in the xfsdump package

rpm magic is probably needed in build/rpm/rpm.spec.in to prevent old versions of xfsdump from being installed alongside the new xfsprogs ... else rpm will report file conflicts, I think? Same will be needed in debian/control... hmm, both should be pretty easy - just change "Conflicts: xfsdump < 2.0.0" to "3.0.0" (and we should make xfsdump v3 at this time too, so its very clear).

Quoted 2 lines

Agreed. I think it's better to leave the debian part to you, and I'll look into the rpm part later.

Both files just need the above-mentioned change. I'll send a patch.

Quoted 2 lines

Any chance you could also review the fsr and estimate manpage patches as they should go in before this one?

No worries - the estimate man page move looks fine (as long as its also removed from xfsdump package, of course).

+//#include "config.h"
shouldn't be there in the final fsr checkin I guess - there is no config.h in xfsprogs.

Quoted 1 line

+ if (fsetxattr(tfd, "X", "X", 1, XATTR_CREATE) != 0) {

the name needs to be namespace prefixed, so that would be:

    fsetxattr(tfd, "user.X", "X", ...);

cheers.

--
Nathan

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs