Skip to contentSkip to conversation

Check name property to determine partition nodes.

PATCH Superseded Benjamin Krill 1 participant 2 messages Jan 23, 2009 Memory technology devices (MTD)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Check name property to determine partition nodes.

SLOF has a further node which could not be evaluate by the current routine. The current routine returns because the node hasn't the required reg property. As fix this patch adds a check to determine the partition child nodes.

---
 drivers/mtd/ofpart.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/mtd/ofpart.c +5 -0
index 9e45b3f..c852cc2 100644
@@ -46,6 +46,11 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
 		const u32 *reg;
 		int len;
 
+		/* check if this is a partition node */
+		partname = of_get_property(pp, "name", &len);
+		if (strcmp(partname, "partition") != 0)
+			continue;
+
 		reg = of_get_property(pp, "reg", &len);
 		if (!reg || (len != 2 * sizeof(u32))) {
 			of_node_put(pp);
Signature · 1 line
1.6.0.6
#1 lore raw

I missed a fix in this patch. I will resend it as v2.

cheers
ben

Quoted 34 lines · * Benjamin Krill | 2009-01-23 16:51:42 [+0100]:

SLOF has a further node which could not be evaluate by the current routine. The current routine returns because the node hasn't the required reg property. As fix this patch adds a check to determine the partition child nodes.

---
drivers/mtd/ofpart.c | 5 +++++

1 files changed, 5 insertions(+), 0 deletions(-)
drivers/mtd/ofpart.c +5 -0
index 9e45b3f..c852cc2 100644
@@ -46,6 +46,11 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
 		const u32 *reg;
 		int len;
 
+		/* check if this is a partition node */
+		partname = of_get_property(pp, "name", &len);
+		if (strcmp(partname, "partition") != 0)
+			continue;
+
 		reg = of_get_property(pp, "reg", &len);
 		if (!reg || (len != 2 * sizeof(u32))) {
 			of_node_put(pp);
Signature · 6 lines
1.6.0.6

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev