Skip to contentSkip to conversation

net: fix xfrm reverse flow lookup for icmp6

PATCH Applied Jiri Pirko 3 participants 3 messages Jan 26, 2009 – Jan 28, 2009

Subsystems (2)
lore
Share & tools
lore

Jiri Pirko

author
#0 lore raw

PATCH 1/1 net: fix xfrm reverse flow lookup for icmp6

This patch fixes the xfrm reverse flow lookup for icmp6 so that icmp6 packets don't get lost over ipsec tunnels. Similar patch is in RHEL5 kernel for a quite long time and I do not see why it isn't in mainline.

Please correct me if I'm missing something.

Jirka

---
 net/ipv6/icmp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
net/ipv6/icmp.c +2 -2
index 4f43384..36dff88 100644
@@ -443,10 +443,10 @@ void icmpv6_send(struct sk_buff *skb, int type, int code, __u32 info,
 	if (xfrm_decode_session_reverse(skb, &fl2, AF_INET6))
 		goto relookup_failed;
 
-	if (ip6_dst_lookup(sk, &dst2, &fl))
+	if (ip6_dst_lookup(sk, &dst2, &fl2))
 		goto relookup_failed;
 
-	err = xfrm_lookup(net, &dst2, &fl, sk, XFRM_LOOKUP_ICMP);
+	err = xfrm_lookup(net, &dst2, &fl2, sk, XFRM_LOOKUP_ICMP);
 	switch (err) {
 	case 0:
 		dst_release(dst);
Signature · 1 line
1.6.0.6
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Jiri Pirko

This patch fixes the xfrm reverse flow lookup for icmp6 so that icmp6 packets don't get lost over ipsec tunnels. Similar patch is in RHEL5 kernel for a quite long time and I do not see why it isn't in mainline.

Please correct me if I'm missing something.

Jirka

Indeed, I have no idea how this one slipped through the cracks. Thanks for picking up on it!

Cheers,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
maintainer Applied
#2 lore raw

From: Herbert Xu <[email protected]>
Date: Wed, 28 Jan 2009 14:48:16 +1100

Quoted 10 lines · Jiri Pirko
Quoted 9 lines

This patch fixes the xfrm reverse flow lookup for icmp6 so that icmp6 packets don't get lost over ipsec tunnels. Similar patch is in RHEL5 kernel for a quite long time and I do not see why it isn't in mainline.

Please correct me if I'm missing something.

Jirka

Quoted 6 lines
Quoted 1 line

Indeed, I have no idea how this one slipped through the cracks. Thanks for picking up on it!

Yep, thanks for sure.

Applied, thanks again.