Skip to contentSkip to conversation

Random MAC address option

PATCH In review Pavel Vasilyev 9 participants 13 messages Jan 27, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Random MAC address option

Makefile.target +2 -1
Index: Makefile.target
===================================================================
@@ -580,7 +580,8 @@
 OBJS+= fdc.o mc146818rtc.o serial.o i8259.o i8254.o pcspk.o pc.o
 OBJS+= cirrus_vga.o apic.o parallel.o acpi.o piix_pci.o
 OBJS+= usb-uhci.o vmmouse.o vmport.o vmware_vga.o hpet.o
-CPPFLAGS += -DHAS_AUDIO -DHAS_AUDIO_CHOICE
+CPPFLAGS += 
+#-DHAS_AUDIO -DHAS_AUDIO_CHOICE
 endif
 ifeq ($(TARGET_BASE_ARCH), ppc)
 CPPFLAGS += -DHAS_AUDIO -DHAS_AUDIO_CHOICE
net.c +39 -9

81 lines not on this page · raw message

net.h +2 -0
Index: net.h
===================================================================
@@ -52,6 +52,8 @@
                                const char *default_model);
 void qemu_handler_true(void *opaque);
 
+unsigned long int random_mac_seed(void);
+
 void do_info_network(void);
 int do_set_link(const char *name, const char *up_or_down);
 
qemu-malloc.c +1 -1
Index: qemu-malloc.c
===================================================================
@@ -35,7 +35,7 @@
 
 void *qemu_malloc(size_t size)
 {
-    return malloc(size);
+    return calloc(1, size);
 }
 
 void *qemu_realloc(void *ptr, size_t size)
Makefile.target +2 -1
Index: Makefile.target
===================================================================
@@ -580,7 +580,8 @@
 OBJS+= fdc.o mc146818rtc.o serial.o i8259.o i8254.o pcspk.o pc.o
 OBJS+= cirrus_vga.o apic.o parallel.o acpi.o piix_pci.o
 OBJS+= usb-uhci.o vmmouse.o vmport.o vmware_vga.o hpet.o
-CPPFLAGS += -DHAS_AUDIO -DHAS_AUDIO_CHOICE
+CPPFLAGS += 
+#-DHAS_AUDIO -DHAS_AUDIO_CHOICE
 endif
 ifeq ($(TARGET_BASE_ARCH), ppc)
 CPPFLAGS += -DHAS_AUDIO -DHAS_AUDIO_CHOICE
net.c +39 -9

81 lines not on this page · raw message

net.h +2 -0
Index: net.h
===================================================================
@@ -52,6 +52,8 @@
                                const char *default_model);
 void qemu_handler_true(void *opaque);
 
+unsigned long int random_mac_seed(void);
+
 void do_info_network(void);
 int do_set_link(const char *name, const char *up_or_down);
 
qemu-malloc.c +1 -1
Index: qemu-malloc.c
===================================================================
@@ -35,7 +35,7 @@
 
 void *qemu_malloc(size_t size)
 {
-    return malloc(size);
+    return calloc(1, size);
 }
 
 void *qemu_realloc(void *ptr, size_t size)
#1 lore raw

PATCH 1/1 Replace strcmp() by strncmp()

Possible SIGSEGV

net.c (working copy) renamed from net.c (revision 6463) +5 -5
Index: net.c
===================================================================
@@ -1568,7 +1586,7 @@
     if (get_param_value(buf, sizeof(buf), "name", p)) {
         name = strdup(buf);
     }
-    if (!strcmp(device, "nic")) {
+    if (!strncmp(device, "nic", 3)) {
         NICInfo *nd;
         uint8_t *macaddr;
 
@@ -1601,13 +1630,13 @@
         vlan->nb_guest_devs++;
         ret = 0;
     } else
-    if (!strcmp(device, "none")) {
+    if (!strncmp(device, "none", 4)) {
         /* does nothing. It is needed to signal that no network cards
            are wanted */
         ret = 0;
     } else
 #ifdef CONFIG_SLIRP
-    if (!strcmp(device, "user")) {
+    if (!strncmp(device, "user", 4)) {
         if (get_param_value(buf, sizeof(buf), "hostname", p)) {
             pstrcpy(slirp_hostname, sizeof(slirp_hostname), buf);
         }
@@ -1622,7 +1651,7 @@
     } else
 #endif
 #ifdef _WIN32
-    if (!strcmp(device, "tap")) {
+    if (!strncmp(device, "tap", 3)) {
         char ifname[64];
         if (get_param_value(ifname, sizeof(ifname), "ifname", p) <= 0) {
             fprintf(stderr, "tap: no interface name\n");
@@ -1633,7 +1662,7 @@
     } else
 #elif defined (_AIX)
 #else
-    if (!strcmp(device, "tap")) {
+    if (!strncmp(device, "tap", 3)) {
         char ifname[64];
         char setup_script[1024], down_script[1024];
         int fd;
#5 lore raw
In reply to Pavel Vasilyev
Quoted 5 lines · Pavel Vasilyev

Index: Makefile.target
===================================================================

Makefile.target line 587

Quoted 9 lines
Makefile.target +2 -1
@@ -580,7 +580,8 @@
 OBJS+= fdc.o mc146818rtc.o serial.o i8259.o i8254.o pcspk.o pc.o
 OBJS+= cirrus_vga.o apic.o parallel.o acpi.o piix_pci.o
 OBJS+= usb-uhci.o vmmouse.o vmport.o vmware_vga.o hpet.o
-CPPFLAGS += -DHAS_AUDIO -DHAS_AUDIO_CHOICE
+CPPFLAGS += 
+#-DHAS_AUDIO -DHAS_AUDIO_CHOICE
 endif
 ifeq ($(TARGET_BASE_ARCH), ppc)
 CPPFLAGS += -DHAS_AUDIO -DHAS_AUDIO_CHOICE

I'm not quite sure how disabling audio relates to MAC addresses..

[..snip..]

Quoted 6 lines

Index: qemu-malloc.c
===================================================================

qemu-malloc.c line 41

Quoted 8 lines
qemu-malloc.c +1 -1
@@ -35,7 +35,7 @@
 
 void *qemu_malloc(size_t size)
 {
-    return malloc(size);
+    return calloc(1, size);
 }
 
 void *qemu_realloc(void *ptr, size_t size)

Nor this..

Signature · 1 line
mailto:[email protected]
#2 lore raw

[Qemu-devel] Re: [PATCH] Replace strcmp() by strncmp()

In reply to Pavel Vasilyev
Quoted 1 line · Pavel Vasilyev

Possible SIGSEGV

I would suggest studying some strncmp implementation and also thinking about the case that 'device' is, say, "nics"...

Jan

Quoted 50 lines

Index: net.c
===================================================================

net.c (working copy) renamed from net.c (revision 6463) +5 -5
@@ -1568,7 +1586,7 @@
     if (get_param_value(buf, sizeof(buf), "name", p)) {
         name = strdup(buf);
     }
-    if (!strcmp(device, "nic")) {
+    if (!strncmp(device, "nic", 3)) {
         NICInfo *nd;
         uint8_t *macaddr;
 
@@ -1601,13 +1630,13 @@
         vlan->nb_guest_devs++;
         ret = 0;
     } else
-    if (!strcmp(device, "none")) {
+    if (!strncmp(device, "none", 4)) {
         /* does nothing. It is needed to signal that no network cards
            are wanted */
         ret = 0;
     } else
 #ifdef CONFIG_SLIRP
-    if (!strcmp(device, "user")) {
+    if (!strncmp(device, "user", 4)) {
         if (get_param_value(buf, sizeof(buf), "hostname", p)) {
             pstrcpy(slirp_hostname, sizeof(slirp_hostname), buf);
         }
@@ -1622,7 +1651,7 @@
     } else
 #endif
 #ifdef _WIN32
-    if (!strcmp(device, "tap")) {
+    if (!strncmp(device, "tap", 3)) {
         char ifname[64];
         if (get_param_value(ifname, sizeof(ifname), "ifname", p) <= 0) {
             fprintf(stderr, "tap: no interface name\n");
@@ -1633,7 +1662,7 @@
     } else
 #elif defined (_AIX)
 #else
-    if (!strcmp(device, "tap")) {
+    if (!strncmp(device, "tap", 3)) {
         char ifname[64];
         char setup_script[1024], down_script[1024];
         int fd;
Signature · 2 lines
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
#6 lore raw
In reply to Pavel Vasilyev
Quoted 19 lines · Pavel Vasilyev

Index: Makefile.target
===================================================================

Makefile.target +2 -1
@@ -580,7 +580,8 @@
 OBJS+= fdc.o mc146818rtc.o serial.o i8259.o i8254.o pcspk.o pc.o
 OBJS+= cirrus_vga.o apic.o parallel.o acpi.o piix_pci.o
 OBJS+= usb-uhci.o vmmouse.o vmport.o vmware_vga.o hpet.o
-CPPFLAGS += -DHAS_AUDIO -DHAS_AUDIO_CHOICE
+CPPFLAGS += 
+#-DHAS_AUDIO -DHAS_AUDIO_CHOICE
 endif
 ifeq ($(TARGET_BASE_ARCH), ppc)
 CPPFLAGS += -DHAS_AUDIO -DHAS_AUDIO_CHOICE

Index: net.c
===================================================================

net.c line 130

Quoted 9 lines
net.c +6 -0
@@ -122,6 +122,24 @@
 
 static VLANState *first_vlan;
 
+unsigned long int random_mac_seed(void) {
+
+    unsigned long int seed = 0;
+    int fd;
+
+    fd = open("/dev/urandom", O_RDONLY);

How is that supposed to work on Windows? And what's wrong with rand()?

Quoted 25 lines
net.c +13 -1
+    if (fd == -1) {
+        perror("open");
+        return 0;
+    }
+    if (read(fd, &seed, sizeof (seed)) < 0) {
+        perror("read");
+        seed = 0;
+    }
+    if (close(fd))
+        perror("close");
+    return seed;
+}
 /***********************************************************/
 /* network device redirectors */
 
@@ -160,7 +178,7 @@
     long int offset;
 
     errno = 0;
-    offset = strtol(p, &last_char, 0);    
+    offset = strtol(p, &last_char, 0);
     if (0 == errno && '\0' == *last_char &&
             offset >= 0 && offset <= 0xFFFFFF) {
         macaddr[3] = (offset & 0xFF0000) >> 16;

net.c line 203

Quoted 8 lines
net.c +1 -1
@@ -179,7 +197,7 @@
                 p++;
             }
         }
-        return 0;    
+        return 0;
     }
 
     return -1;

I don't think these whitespace changes should be there.

Kevin

#7 lore raw
In reply to Pavel Vasilyev
Quoted 1 line · Pavel Vasilyev

+ if (strstr(p, "macrandom")) {

I take this means -net macaddr=macrandom will give the random macaddr after this patch? please document this magic in qemu-doc.texi and --help.

#8 lore raw
Quoted 6 lines · Riku Voipio
Quoted 1 line · Pavel Vasilyev

+ if (strstr(p, "macrandom")) {

I take this means -net macaddr=macrandom will give the random macaddr after this patch? please document this magic in qemu-doc.texi and --help.

Generating a random MAC address everytime you boot a guest seems like a very odd thing todo. MAC addresses should be randomly generated once, and then fixed for the duration of existance of that guest, across reboots.If you generate a random MAC on every boot, the OS will think its NIC has been removed, and a new one added on every boot.

Daniel

Signature · 4 lines
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
#9 lore raw

Daniel P. Berrange writes ("Re: [Qemu-devel] [PATCH] Random MAC address option"):

Quoted 4 lines · Riku Voipio
Quoted 3 lines

I take this means -net macaddr=macrandom will give the random macaddr after this patch? please document this magic in qemu-doc.texi and --help.

Surely macaddr=macrandom' is tautologous ? What's wrong with macaddr=random' ?

Quoted 5 lines

Generating a random MAC address everytime you boot a guest seems like a very odd thing todo. MAC addresses should be randomly generated once, and then fixed for the duration of existance of that guest, across reboots.If you generate a random MAC on every boot, the OS will think its NIC has been removed, and a new one added on every boot.

Whether or not this is a problem depends on your operating system. Indeed having a new MAC address each time can have privacy advantages in certain IPv6 configurations!

If you want the MAC address to be persistent, where should qemu store the MAC address ?

Ian.

#11 lore raw
In reply to Pavel Vasilyev
Quoted 1 line

+        if (strstr(p, "macrandom")) {

I'm not convinced this is a useful feature.

We already allow the user to specify a mac address, so this feature can be trivially implemented (and better supported) by a management app or simple shell script.

In addition to the issues other people have raised, there's no validation that the random value is actually a valid mac address, and no conflict resolution to avoid duplicate addresses when multiple NICs are present.

Paul

#12 lore raw
Quoted 9 lines · Paul Brook
Quoted 2 lines

+ if (strstr(p, "macrandom")) {

I'm not convinced this is a useful feature.

We already allow the user to specify a mac address, so this feature can be trivially implemented (and better supported) by a management app or simple shell script.

In addition to the issues other people have raised, there's no validation that the random value is actually a valid mac address, and no conflict resolution to avoid duplicate addresses when multiple NICs are present.

I agree. It gives a false sense of security.

Regards,

Anthony Liguori

Quoted 4 lines

Paul

#3 lore raw

Re: [Qemu-devel] Re: [PATCH] Replace strcmp() by strncmp()

In reply to Jan Kiszka
Quoted 8 lines · On Tuesday 27 January 2009 12:28:55 Jan Kiszka wrote:
Quoted 1 line · Pavel Vasilyev

Possible SIGSEGV

I would suggest studying some strncmp implementation and also thinking about the case that 'device' is, say, "nics"...

Jan

strncasecmp(); ???

#10 lore raw
In reply to Riku Voipio
Quoted 5 lines · On Tuesday 27 January 2009 13:15:41 Riku Voipio wrote:
Quoted 1 line · Pavel Vasilyev

+ if (strstr(p, "macrandom")) {

I take this means -net macaddr=macrandom will give the random macaddr after this patch?

-net nic,macrandom

Quoted 2 lines

please document this magic in
qemu-doc.texi and --help.

#4 lore raw

Re: [Qemu-devel] Re: [PATCH] Replace strcmp() by strncmp()

In reply to Jan Kiszka
Quoted 5 lines · On Tuesday 27 January 2009 12:28:55 Jan Kiszka wrote:
Quoted 1 line · Pavel Vasilyev

Possible SIGSEGV

I would suggest studying some strncmp implementation and also thinking about the case that 'device' is, say, "nics"...

1. "nics" is other option
2. strncmp() conforming with next standarts: SVID 3, POSIX, BSD 4.3, ISO 9899
3. For case insensitivity - use strncasecmp(), For OSes where there is no this function, it is possible to use macro.