Enable bit 11 in _PDC to advertise hw coord
Subsystems (2)
PATCH 1/1 Enable bit 11 in _PDC to advertise hw coord
Bit 11 in intel PDC definitions is meant for OS capability to handle hardware coordination of P-states. In Linux we have always supported hwardware coordination of P-states. Just let the BIOSes know that we support it, by setting this bit.
Some BIOSes use this bit to choose between hardware or software coordination and without this change below, BIOSes switch to software coordination, which is not very optimal in terms of power consumption and extra wakeups from idle.
--- include/acpi/pdc_intel.h | 2 ++ 1 file changed, 2 insertions(+)
include/acpi/pdc_intel.h +2 -0
@@ -14,6 +14,7 @@#define ACPI_PDC_SMP_T_SWCOORD (0x0080)#define ACPI_PDC_C_C1_FFH (0x0100)#define ACPI_PDC_C_C2C3_FFH (0x0200) +#define ACPI_PDC_SMP_P_HWCOORD (0x0800)#define ACPI_PDC_EST_CAPABILITY_SMP (ACPI_PDC_SMP_C1PT | \ ACPI_PDC_C_C1_HALT | \
@@ -22,6 +23,7 @@#define ACPI_PDC_EST_CAPABILITY_SWSMP (ACPI_PDC_SMP_C1PT | \ ACPI_PDC_C_C1_HALT | \ ACPI_PDC_SMP_P_SWCOORD | \ + ACPI_PDC_SMP_P_HWCOORD | \ ACPI_PDC_P_FFH)#define ACPI_PDC_C_CAPABILITY_SMP (ACPI_PDC_SMP_C2C3 | \
Quoted 9 lines · Venkatesh
Bit 11 in intel PDC definitions is meant for OS capability to handle hardware coordination of P-states. In Linux we have always supported hwardware coordination of P-states. Just let the BIOSes know that we support it, by setting this bit.
Some BIOSes use this bit to choose between hardware or software coordination and without this change below, BIOSes switch to software coordination, which is not very optimal in terms of power consumption and extra wakeups from idle.
I can confirm that this fixes the excessive reschedule ipi count on an x60 with the ondemand governor. Can we please get this into 2.6.29?
Quoted 27 lines
Signed-off-by Venkatesh Pallipadi <[email protected]>--- include/acpi/pdc_intel.h | 2 ++ 1 file changed, 2 insertions(+)Index:
linux-2.6/include/acpi/pdc_intel.h
===================================================================include/acpi/pdc_intel.h +2
-0@@ -14,6 +14,7 @@#define ACPI_PDC_SMP_T_SWCOORD (0x0080)#define ACPI_PDC_C_C1_FFH (0x0100)#define ACPI_PDC_C_C2C3_FFH (0x0200) +#define ACPI_PDC_SMP_P_HWCOORD (0x0800)#define ACPI_PDC_EST_CAPABILITY_SMP (ACPI_PDC_SMP_C1PT | \ ACPI_PDC_C_C1_HALT | \@@ -22,6 +23,7 @@#define ACPI_PDC_EST_CAPABILITY_SWSMP (ACPI_PDC_SMP_C1PT | \ ACPI_PDC_C_C1_HALT | \ ACPI_PDC_SMP_P_SWCOORD | \ + ACPI_PDC_SMP_P_HWCOORD | \ ACPI_PDC_P_FFH)#define ACPI_PDC_C_CAPABILITY_SMP (ACPI_PDC_SMP_C2C3 | \
Signature · 1 line
Jens Axboe
Quoted 7 lines · Jens Axboe
Quoted 6 lines · Venkatesh
Bit 11 in intel PDC definitions is meant for OS capability to handle hardware coordination of P-states. In Linux we have always supported hwardware coordination of P-states. Just let the BIOSes know that we support it, by setting this bit.
Quoted 6 lines
Quoted 3 lines
Some BIOSes use this bit to choose between hardware or software coordination and without this change below, BIOSes switch to software coordination, which is not very optimal in terms of power consumption and extra wakeups from idle.
I can confirm that this fixes the excessive reschedule ipi count on an x60 with the ondemand governor. Can we please get this into 2.6.29?
And, after that, -stable?
Signature · 4 lines
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
Quoted 8 lines · Henrique de Moraes Holschuh
Quoted 7 lines · Jens Axboe
Quoted 6 lines · Venkatesh
Bit 11 in intel PDC definitions is meant for OS capability to handle hardware coordination of P-states. In Linux we have always supported hwardware coordination of P-states. Just let the BIOSes know that we support it, by setting this bit.
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Some BIOSes use this bit to choose between hardware or software coordination and without this change below, BIOSes switch to software coordination, which is not very optimal in terms of power consumption and extra wakeups from idle.
I can confirm that this fixes the excessive reschedule ipi count on an x60 with the ondemand governor. Can we please get this into 2.6.29?
And, after that, -stable?
Agreed. This should also go to -stable once it gets into mainline.
Thanks,
Venki
Quoted 13 lines · Venkatesh
Quoted 12 lines · Henrique de Moraes Holschuh
Quoted 11 lines · Jens Axboe
Quoted 9 lines · Venkatesh
Bit 11 in intel PDC definitions is meant for OS capability to handle hardware coordination of P-states. In Linux we have always supported hwardware coordination of P-states. Just let the BIOSes know that we support it, by setting this bit.
Some BIOSes use this bit to choose between hardware or software coordination and without this change below, BIOSes switch to software coordination, which is not very optimal in terms of power consumption and extra wakeups from idle.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
I can confirm that this fixes the excessive reschedule ipi count on an x60 with the ondemand governor. Can we please get this into 2.6.29?
And, after that, -stable?
Agreed. This should also go to -stable once it gets into mainline.
Can someone send [email protected] the git commit id when it goes into Linus's tree?
thanks,
greg k-h
Quoted 17 lines · Greg KH
Quoted 16 lines · Venkatesh
Quoted 15 lines · Henrique de Moraes Holschuh
Quoted 13 lines · Jens Axboe
Quoted 9 lines · Venkatesh
Bit 11 in intel PDC definitions is meant for OS capability to handle hardware coordination of P-states. In Linux we have always supported hwardware coordination of P-states. Just let the BIOSes know that we support it, by setting this bit.
Some BIOSes use this bit to choose between hardware or software coordination and without this change below, BIOSes switch to software coordination, which is not very optimal in terms of power consumption and extra wakeups from idle.
I can confirm that this fixes the excessive reschedule ipi count on an x60 with the ondemand governor. Can we please get this into 2.6.29?
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
And, after that, -stable?
Agreed. This should also go to -stable once it gets into mainline.
Can someone send [email protected] the git commit id when it goes into Linus's tree?
It's d96f94c604453f87fe24154b87e1e9a3a72511f8, I got it now.
thanks,
greg k-h
Len Brown
reviewerapplied
thanks,
--
Len Brown, Intel Open Source Technology Center
Quoted 41 lines · Venkatesh
Bit 11 in intel PDC definitions is meant for OS capability to handle hardware coordination of P-states. In Linux we have always supported hwardware coordination of P-states. Just let the BIOSes know that we support it, by setting this bit.
Some BIOSes use this bit to choose between hardware or software coordination and without this change below, BIOSes switch to software coordination, which is not very optimal in terms of power consumption and extra wakeups from idle.
Signed-off-by Venkatesh Pallipadi <[email protected]>--- include/acpi/pdc_intel.h | 2 ++ 1 file changed, 2 insertions(+)Index:
linux-2.6/include/acpi/pdc_intel.h
===================================================================include/acpi/pdc_intel.h +2
-1@@ -14,6 +14,7 @@#define ACPI_PDC_SMP_T_SWCOORD (0x0080)#define ACPI_PDC_C_C1_FFH (0x0100)#define ACPI_PDC_C_C2C3_FFH (0x0200) +#define ACPI_PDC_SMP_P_HWCOORD (0x0800)#define ACPI_PDC_EST_CAPABILITY_SMP (ACPI_PDC_SMP_C1PT | \ ACPI_PDC_C_C1_HALT | \@@ -22,6 +23,7 @@#define ACPI_PDC_EST_CAPABILITY_SWSMP (ACPI_PDC_SMP_C1PT | \ ACPI_PDC_C_C1_HALT | \ ACPI_PDC_SMP_P_SWCOORD | \ + ACPI_PDC_SMP_P_HWCOORD | \ ACPI_PDC_P_FFH)#define ACPI_PDC_C_CAPABILITY_SMP (ACPI_PDC_SMP_C2C3 | \ --To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html